Skip to content

Revert "fix: add sidebar highlighting for direct route URLs" #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naman9271 merged 1 commit into from
Jan 1, 2026
+4 −127
Merged

Revert "fix: add sidebar highlighting for direct route URLs" #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/app/docs/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Layout } from 'nextra-theme-docs'
import 'nextra-theme-docs/style.css'
import { DocsNavbar, DocsFooter, DocsBanner, DirectRouteHighlighter } from '@/components/docs/index'
import { DocsNavbar, DocsFooter, DocsBanner } from '@/components/docs/index'
import { Inter, JetBrains_Mono } from "next/font/google"
import { Suspense } from 'react'
import { ThemeProvider } from "next-themes"
Expand Down Expand Up @@ -43,7 +43,7 @@ export default async function DocsLayout({ children }: Props) {
const branch = getBranchForVersion(defaultVersion)

// Build page map for the default version
const { pageMap, directRouteMap } = await buildPageMapForBranch(branch)
const { pageMap } = await buildPageMapForBranch(branch)

return (
<html lang="en" suppressHydrationWarning>
Expand All @@ -65,7 +65,6 @@ export default async function DocsLayout({ children }: Props) {
title: "On This Page"
}}
>
<DirectRouteHighlighter directRouteMap={directRouteMap || {}} />
{children}
</Layout>
</ThemeProvider>
Expand Down
13 changes: 2 additions & 11 deletions src/app/docs/page-map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ type FolderNode = { kind: 'Folder'; name: string; route: string; children: PageM
{ file: 'release-notes.md' }
]],
['Install & Configure', [
{ file: 'get-started.md' },
// { file: 'get-started.md' },
{ file: 'pre-reqs.md' },
{ file: 'start-from-ocm.md' },
{ file: 'setup-limitations.md' },
Expand Down Expand Up @@ -346,14 +346,5 @@ type FolderNode = { kind: 'Folder'; name: string; route: string; children: PageM
// normalizePageMap has compatible types now; remove stale suppressor
const pageMap = normalizePageMap(_pageMap)

// Build a map of direct routes to their canonical category routes
const directRouteMap: Record<string, string> = {}
for (const { alias, fp } of aliases) {
if (DIRECT_ROOT && fp.startsWith(`${DIRECT_ROOT}/`)) {
const fileName = fp.split('/').pop()!.replace(/\.(md|mdx)$/i, '')
directRouteMap[`/docs/direct/${fileName}`] = `/docs/${alias}`
}
}

return { pageMap, routeMap, filePaths: allDocFiles, branch, directRouteMap }
return { pageMap, routeMap, filePaths: allDocFiles, branch }
}
112 changes: 0 additions & 112 deletions src/components/docs/DirectRouteHighlighter.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/docs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ export { default as DocsNavbar } from './DocsNavbar';
export { default as DocsFooter } from './DocsFooter';
export { DocsBanner } from './DocsBanner';
export { default as EditViewSourceButtons } from './EditViewSourceButtons';
export { DirectRouteHighlighter } from './DirectRouteHighlighter';