Skip to content

✨ feature : check extensioninitialcontextname set #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubestellar-prow merged 7 commits into from
Aug 25, 2025
Merged

✨ feature : check extensioninitialcontextname set #499

kubestellar-prow merged 7 commits into from
Aug 25, 2025

Conversation

@redpinecube
Copy link
Contributor

@redpinecube redpinecube commented Aug 4, 2025 •
edited
Loading

Summary

Implements : CheckExtensionInitialContextNameSet.

Related issue(s)

#388
redpinecube#26

@kubestellar-prow kubestellar-prow bot added dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2025
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Aug 4, 2025

Hi @redpinecube. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2025
@redpinecube redpinecube mentioned this pull request Aug 4, 2025
Merged
@redpinecube
Copy link
Contributor Author

redpinecube commented Aug 4, 2025

@rxinui

@redpinecube redpinecube force-pushed the feature/check-extensioninitialcontextname-set branch from 7922bcc to e52e66f Compare August 25, 2025 19:50
@kubestellar-prow kubestellar-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2025
rxinui
rxinui reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@rxinui rxinui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubestellar-prow kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2025
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Aug 25, 2025

LGTM label has been added.

DetailsGit tree hash: 5328318c7821f79a05d7da48a4e3423b2d27875e

@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rxinui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@kubestellar-prow kubestellar-prow bot merged commit ed97d57 into kubestellar:main Aug 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rxinui rxinui rxinui left review comments

Assignees

@rxinui rxinui

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redpinecube @rxinui