Skip to content

✨Change the Helm chart to ensure kubeflex-system ns existence #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubestellar-prow merged 1 commit into from
Sep 18, 2025
Merged

✨Change the Helm chart to ensure kubeflex-system ns existence #542

kubestellar-prow merged 1 commit into from
Sep 18, 2025

Conversation

@francostellari
Copy link
Contributor

@francostellari francostellari commented Sep 11, 2025

Summary

Change the Helm chart to ensure kubeflex-system ns existence.

This allows one to install the chart without previously creating the kubeflex-system or passing the kubeflex-system namespace on the helm CLI.

This change is backwards compatible with both:

kubectl create kubeflex-system
helm upgrade --install kubeflex-operator <chart>

and

helm upgrade --install kubeflex-operator -n kubeflex-system --create-namespace <chart>

Edited files:

  • chart to add the new namespace template
  • docs to remove the longer commands
  • makefile

Related issue(s)

Fixes #541

@kubestellar-prow kubestellar-prow bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2025
@francostellari
Copy link
Contributor Author

francostellari commented Sep 11, 2025

/assign

ingpaolodettori-dev

This comment was marked as outdated.

Sign in to view

@kubestellar kubestellar deleted a comment from kubestellar-prow bot Sep 17, 2025
@francostellari
Ensure kubeflex-system ns
b17b122 
Signed-off-by: francostellari <[email protected]>

Ensure kubeflex-system ns

Signed-off-by: francostellari <[email protected]>

Ensure kubeflex-system ns

Signed-off-by: francostellari <[email protected]>
@pdettori
Copy link
Contributor

pdettori commented Sep 17, 2025 •
edited
Loading

/lgtm
/approve

@kubestellar-prow kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Sep 17, 2025

LGTM label has been added.

DetailsGit tree hash: 2ac69bcf72eecfa00f429ef8362279ccc230f60a

@ingpaolodettori-dev
Copy link

ingpaolodettori-dev commented Sep 18, 2025

/check-dco

@ingpaolodettori-dev
Copy link

ingpaolodettori-dev commented Sep 18, 2025

/approve

@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingpaolodettori-dev, pdettori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@kubestellar-prow kubestellar-prow bot merged commit f96b74a into kubestellar:main Sep 18, 2025
9 checks passed
@MikeSpreitzer
Copy link
Contributor

MikeSpreitzer commented Dec 15, 2025 •
edited
Loading

I suspect that making the Namespace conditional on its not already existing is what is causing test/e2e/test-controller-image-update.sh from #519 to fail now. I find that when I try that test, after the helm upgrade the kubeflex-system namespace no longer exists.

MikeSpreitzer
MikeSpreitzer reviewed Dec 15, 2025
View reviewed changes
chart/templates/namespace.yaml
@@ -0,0 +1,6 @@
{{- if and (ne .Release.Namespace "kubeflex-system") (not (lookup "v1" "Namespace" "" "kubeflex-system")) }}
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After writing this question, I feel silly even asking it: https://kubernetes.slack.com/archives/C0NH30761/p1765780162847849

@MikeSpreitzer MikeSpreitzer mentioned this pull request Dec 19, 2025
Closed
@MikeSpreitzer MikeSpreitzer mentioned this pull request Jan 3, 2026
Closed
1 task
clubanderson added a commit that referenced this pull request Jan 15, 2026
@clubanderson
Merge pull request #542 from kubestellar/fix-pr-verifier-dependabot
5f34322 
ci: skip pr-verifier for dependabot PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer left review comments

+1 more reviewer

@ingpaolodettori-dev ingpaolodettori-dev ingpaolodettori-dev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pdettori pdettori

@francostellari francostellari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Enhance the Helm chart by ensuring that the kubeflex-system exists

4 participants

@francostellari @pdettori @ingpaolodettori-dev @MikeSpreitzer