🐛 Restore stripping of leading "v" from container image tag #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubestellar-prow
bot
added
dco-signoff: yes
Contributor
Author
|
@RayyanSeliya |
This is needed because .github/workflows/goreleaser.yml says
```shell
make chart IMG=${{ env.REGISTRY }}/${{ env.OPERATOR_IMAGE }}:${{github.ref_name}}
```
and the tag has a leading "v" but the controller-manager container
image tag does not.
Signed-off-by: Mike Spreitzer <[email protected]>
MikeSpreitzer
force-pushed
the
unbreak-tag
branch
from
c02fd8e to
627b380
Compare
Contributor
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 50627fe96bd9cccd6625356ed589064864930a89 |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubestellar-prow
bot
added
the
approved
This was referenced Dec 16, 2025
This was referenced Dec 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the stripping of a leading "v" from the image tag in the Makefile target
chart.This is needed because .github/workflows/goreleaser.yml says
and the tag has a leading "v" but the controller-manager container image tag does not.
This stripping was erroneously removed in #519 .
Related issue(s)
This takes a step towards resolving #588; that Issue will not be fully resolved until a new release is made.