Skip to content

🐛 Add to E2E test a workaround to context bug #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubestellar-prow merged 3 commits into from
Jan 6, 2026
Merged

🐛 Add to E2E test a workaround to context bug #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
681f914
Add to E2E test a workaround to context bug
MikeSpreitzer Dec 20, 2025
b22d416
Use kflex from local source instead of whatever is installed
MikeSpreitzer Dec 20, 2025
b7b5954
Fix by removing kubeflex extension
MikeSpreitzer Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/e2e/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ SRC_DIR="$(cd $(dirname "${BASH_SOURCE[0]}") && pwd)"

${SRC_DIR}/cleanup.sh
${SRC_DIR}/setup-kubeflex.sh --release "${release}"
cfgfile="${KUBECONFIG:-$HOME/.kube/config}"
if [[ "$(yq -o=json .extensions "$cfgfile" )" =~ ^[[] ]]; then
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern ^[[] is incorrect for checking if extensions is an array. The pattern has an unmatched opening bracket and will only match a literal '[' at the start. Use ^\[ instead to properly escape the bracket, or use yq to check the type directly with a command like yq '.extensions | type' \"$cfgfile\".

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@MikeSpreitzer MikeSpreitzer Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing the alleged results from type. I will stick with string matching.

mspreitz@mjs13 kubeflex % yq '.extensions | type' ~/.kube/config
!!seq
mspreitz@mjs13 kubeflex % yq '.extensions ' ~/.kube/config 
[]
mspreitz@mjs13 kubeflex % yq '.extension | type ' ~/.kube/config
!!null

yq '.extensions |= [ .[] | select(.name != "kubeflex") ]' "$cfgfile" > $$
mv -f -- "$cfgfile" "${cfgfile}.bak"
mv -- $$ "$cfgfile"
Comment on lines +51 to +53
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using $$ (current shell PID) as a temporary filename creates a potential race condition if multiple instances run concurrently. Consider using mktemp to create a unique temporary file instead.

Suggested change
yq '.extensions |= [ .[] | select(.name != "kubeflex") ]' "$cfgfile" > $$
mv -f -- "$cfgfile" "${cfgfile}.bak"
mv -- $$ "$cfgfile"
tmpfile="$(mktemp "${cfgfile}.XXXXXX")"
yq '.extensions |= [ .[] | select(.name != "kubeflex") ]' "$cfgfile" > "$tmpfile"
mv -f -- "$cfgfile" "${cfgfile}.bak"
mv -- "$tmpfile" "$cfgfile"

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@MikeSpreitzer MikeSpreitzer Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are not multiple concurrent instaces. This is not a problem.

fi
${SRC_DIR}/manage-type-k8s.sh
${SRC_DIR}/manage-type-vcluster.sh
${SRC_DIR}/manage-type-external.sh
Expand Down