Skip to content

✨feat: add informers, listers, and codegen for tenancy APIs #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubestellar-prow merged 17 commits into from
Jan 9, 2026
Merged

✨feat: add informers, listers, and codegen for tenancy APIs #599

kubestellar-prow merged 17 commits into from
Jan 9, 2026

Conversation

@rishi-jat
Copy link
Contributor

@rishi-jat rishi-jat commented Dec 25, 2025

Summary

Completes typed client support by adding generated shared informers, typed listers,
and reproducible code-generation tooling for tenancy APIs.

Follows standard Kubernetes client-go conventions.

Fixes #277

@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Dec 25, 2025
@github-actions
Copy link

github-actions bot commented Dec 25, 2025

Thank you for submitting your first Pull Request to KubeStellar. We are delighted to have you in our Universe!

@kubestellar-prow kubestellar-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 25, 2025
@rishi-jat
Copy link
Contributor Author

rishi-jat commented Dec 25, 2025

/cc @MikeSpreitzer

MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 27, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 28, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 29, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 29, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 29, 2025
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Dec 29, 2025
View reviewed changes
@MikeSpreitzer
Copy link
Contributor

MikeSpreitzer commented Dec 29, 2025

This PR needs evidence that it works as intended.
The functionality in this PR should be tested in CI.

MikeSpreitzer
MikeSpreitzer reviewed Dec 29, 2025
View reviewed changes
@katara-Jayprakash
Copy link
Contributor

katara-Jayprakash commented Jan 3, 2026

@rishi-jat hope you are doing well, could you fix these review points ?

@rishi-jat
Copy link
Contributor Author

rishi-jat commented Jan 3, 2026

Will do this as soon as possible. I’m currently out of town on holiday until 7 January and will address all the suggestions after that. Thanks!

@rishi-jat
Update code generation script and .gitignore
7a4efbf 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Fix absolute path for GOBIN in code generation script
a7d6420 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Simplify path handling in code generation script
b1ed35c 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Remove manually created generated code to regenerate with code-generator
198ad29 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Add genclient markers to API types for code generation
c89f210 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Fix client-gen input paths
be542f7 
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Add generated clientset, informers, and listers
2b70434 
Generated using k8s.io/code-generator v0.32.10:
- client-gen for typed clientset
- lister-gen for listers
- informer-gen for informers

API group: tenancy.kflex.kubestellar.org/v1alpha1
CRDs: ControlPlane, PostCreateHook (cluster-scoped)

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Add verify-codegen.sh for CI verification
e8a7a4b 
- New script compares freshly generated code against committed code
- Makefile verify-codegen target now uses verify-codegen.sh
- Removed dependency on update-codegen.sh (which requires clean tree)

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Simplify code-generation.md per maintainer feedback
416733e 
Signed-off-by: Rishi Jat <[email protected]>
MikeSpreitzer
MikeSpreitzer reviewed Jan 8, 2026
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Jan 8, 2026
View reviewed changes
@rishi-jat
Consolidate to single SchemeBuilder in register.go per maintainer fee…
1487ba8 
…dback and fix remaining comment

Signed-off-by: Rishi Jat <[email protected]>
MikeSpreitzer
MikeSpreitzer reviewed Jan 9, 2026
View reviewed changes
MikeSpreitzer
MikeSpreitzer reviewed Jan 9, 2026
View reviewed changes
@MikeSpreitzer MikeSpreitzer mentioned this pull request Jan 9, 2026
Merged
MikeSpreitzer
MikeSpreitzer reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments left, could be fixed in this PR or a later one.
/lgtm
Thanks!

@kubestellar-prow kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Jan 9, 2026

LGTM label has been added.

DetailsGit tree hash: 588be97d0b30c0701a4bbb138d663b2cbc0f8146

@kubestellar-prow kubestellar-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
MikeSpreitzer
MikeSpreitzer reviewed Jan 9, 2026
View reviewed changes
api/v1alpha1/doc.go Outdated

// Package v1alpha1 contains API Schema definitions for the tenancy v1alpha1 API group
// +kubebuilder:object:generate=true
// +k8s:deepcopy-gen=package
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CF https://github.com/kubestellar/kubestellar/blob/main/api/control/v1alpha1/doc.go

Copy link
Contributor Author

@rishi-jat rishi-jat Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

Copy link
Contributor Author

@rishi-jat rishi-jat Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Contributor

@MikeSpreitzer MikeSpreitzer Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fixed" means that the removal was undone, right? Why was the removal undone?

Copy link
Contributor Author

@rishi-jat rishi-jat Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. Here's what happened:

  1. First commit: I removed both +k8s:deepcopy-gen=package AND +kubebuilder:object:generate=true
  2. This caused the CI build to fail with errors like "DeepCopyInto undefined"
  3. Second commit: I restored only +kubebuilder:object:generate=true because it's needed for controller-gen to generate deepcopy methods

Current state of doc.go:

// +kubebuilder:object:generate=true
// +groupName=tenancy.kflex.kubestellar.org

The +k8s:deepcopy-gen=package marker is removed as you requested. The +kubebuilder:object:generate=true marker remains because without it, controller-gen doesn't generate the DeepCopyInto() methods that the code depends on.

Copy link
Contributor Author

@rishi-jat rishi-jat Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should I follow the kubestellar pattern exactly and remove the kubebuilder marker too? If so, how does kubestellar generate its deepcopy methods?

@rishi-jat
Copy link
Contributor Author

rishi-jat commented Jan 9, 2026

/retest

MikeSpreitzer
MikeSpreitzer reviewed Jan 9, 2026
View reviewed changes
config/rbac/role.yaml
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are beyond the scope of this PR and are not mentioned in the PR's opening comment.

MikeSpreitzer
MikeSpreitzer approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough to merge, although there are still some open comments.
/lgtm
/approve

@kubestellar-prow kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Jan 9, 2026

LGTM label has been added.

DetailsGit tree hash: a53443e192d45e7c0650cdd7f7fd1673fadcae38

@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@kubestellar-prow kubestellar-prow bot merged commit 3d600f3 into kubestellar:main Jan 9, 2026
9 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2026
Closed
@clubanderson
Copy link
Contributor

clubanderson commented Jan 12, 2026

/retest

clubanderson added a commit that referenced this pull request Jan 15, 2026
@clubanderson
Merge pull request #599 from kubestellar/remove-stale-workflow
d6477b2 
chore: remove stale workflow in favor of Prow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

+1 more reviewer

@Atharv3221 Atharv3221 Atharv3221 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MikeSpreitzer MikeSpreitzer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Add typed clients

5 participants

@rishi-jat @MikeSpreitzer @katara-Jayprakash @clubanderson @Atharv3221