-
Notifications
You must be signed in to change notification settings - Fork 52
✨ Migrate from NGINX Ingress to Gateway API with NGINX Gateway Fabric #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9121790 to
cd8628d
Compare
This comprehensive migration replaces all NGINX Ingress resources with Gateway API equivalents: Key Changes: - Replace NGINX Ingress Controller with NGINX Gateway Fabric v2.3.0 - Implement Gateway API v1.4.1 with Gateway, GatewayClass, and HTTPRoute resources - Add Gateway API reconcilers in pkg/reconcilers/shared/gateway.go - Update all control plane reconcilers (k8s, k3s, ocm, vcluster) to use Gateway API - Replace ingress.go with gateway.go across reconciler packages - Update installation scripts to use NGINX Gateway Fabric - Add HTTPS support with both HTTP (80) and HTTPS (443) listeners - Remove all NGINX Ingress dependencies and resources - Update documentation and test scripts - Add necessary Gateway API RBAC permissions Signed-off-by: mavrick-1 <[email protected]>
cd8628d to
b087216
Compare
|
@francostellari @MikeSpreitzer can you ptal? Maybe we can avoid the nginx support issues sooner than expected. |
|
We need evidence that this works. |
|
KubeFlex needs the routing into the hosting cluster to support TLS passthrough (https://github.com/kubestellar/kubeflex/blob/main/docs/users.md#install-kubeflex-on-an-existing-cluster). If I understand correctly, the Gateway API provides that only through a TLSRoute object --- which is not in the standard channel of the Gateway API. |
|
@MAVRICK-1 status ? |
|
Hi @francostellari, this PR needs a rebase to resolve conflicts with the main branch. Could you please rebase and push? git fetch origin
git rebase origin/main
git push --force-with-leaseThanks! |
|
Hi @MAVRICK-1 👋 This PR needs a rebase to resolve conflicts with the main branch. You can do this with: git fetch origin
git rebase origin/main
# Resolve any conflicts if needed
git push --force-with-leaseOnce rebased, the CI checks will run again. Let us know if you need any help! |
@clubanderson is that u , or AI generated ? |
This comprehensive migration replaces all NGINX Ingress resources with Gateway API equivalents:
Key Changes:
Fixes #601