🌱 Fixup issues in E2E testing #602
Conversation
kubestellar-prow
bot
added
dco-signoff: yes
MikeSpreitzer
force-pushed
the
fixup-e2e
branch
from
edb5611 to
b374cca
Compare
MikeSpreitzer
requested review from
Copilot,
pdettori and
waltforme
and removed request for
Copilot and
waltforme
MikeSpreitzer
force-pushed
the
fixup-e2e
branch
from
b374cca to
a595faa
Compare
1. Update the release process to include E2E testing of the new release. 2. Fix organization and other issues in the documentation of E2E testing. 3. Fix the indenting in test/e2e/setup-kubeflex.sh. 4. Make test/e2e/setup-kubeflex.sh follow the instructions of the release being tested. 5. Describe input to test/e2e/setup-kubeflex.sh in `on.workflow_call`. Signed-off-by: Mike Spreitzer <[email protected]>
MikeSpreitzer
force-pushed
the
fixup-e2e
branch
from
a595faa to
2cfcc3c
Compare
Signed-off-by: Mike Spreitzer <[email protected]>
MikeSpreitzer
force-pushed
the
fixup-e2e
branch
from
451bca9 to
10251b2
Compare
Signed-off-by: Mike Spreitzer <[email protected]>
|
Successfully tested against local source by CI (https://github.com/kubestellar/kubeflex/actions/runs/20709952170). Successfully tested against release v0.9.1 at https://github.com/MikeSpreitzer/kubeflex/actions/runs/20709969498 Successfully demonstrated that release v0.9.2 is broken at https://github.com/MikeSpreitzer/kubeflex/actions/runs/20710030611 |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: f201a267e0f3f0493132ce1ff8fc2bfc59618fc8 |
There was a problem hiding this comment.
Pull request overview
This PR addresses remaining issues from #594 related to E2E testing infrastructure. It improves the release process by adding E2E validation, fixes documentation organization, and enhances the test setup script to properly handle different release versions with correct installation methods.
Key changes:
- Added E2E testing as a required step in the release process
- Enhanced test setup script to use the official installation script for releases and handle version-specific installation differences
- Standardized workflow inputs for better integration with other workflows
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/setup-kubeflex.sh | Updated to use official installation script for releases and handle version-specific Helm installation patterns |
| test/e2e/README.md | Reorganized and simplified documentation structure for clarity |
| docs/contributors.md | Added E2E testing validation step to the release process |
| .github/workflows/test-e2e.yaml | Added workflow_call inputs to enable programmatic invocation with release parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/e2e/setup-kubeflex.sh
Outdated
|
|
||
| bash <(curl -s https://raw.githubusercontent.com/kubestellar/kubeflex/refs/tags/${release}/scripts/install-kubeflex.sh) --version $release --ensure-folder bin --strip-bin -X | ||
|
|
||
| if [[ "${release}" < v0.9.2 ]]; then |
There was a problem hiding this comment.
String comparison using < will perform lexicographic comparison, not semantic version comparison. This will fail for versions like v0.10.0 or v0.9.10, which would be considered 'less than' v0.9.2 lexicographically. Use a proper version comparison function or tool like sort -V to compare semantic versions.
docs/contributors.md
Outdated
| ``` | ||
| Wait until goreleaser completes the release process. | ||
|
|
||
| 1. Invoke [the E2E test workflow](.github/workflows/test-e2e.yaml) on |
There was a problem hiding this comment.
The file path '.github/workflows/test-e2e.yaml' is a relative path from the docs directory, but it should be relative to the repository root or use an absolute GitHub URL. The correct relative path from the docs directory would be '../.github/workflows/test-e2e.yaml'.
| 1. Invoke [the E2E test workflow](.github/workflows/test-e2e.yaml) on | |
| 1. Invoke [the E2E test workflow](../.github/workflows/test-e2e.yaml) on |
Signed-off-by: Mike Spreitzer <[email protected]>
MikeSpreitzer
force-pushed
the
fixup-e2e
branch
from
fb81f77 to
ac3eb2e
Compare
|
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: c7a348ee7cdc3799d38b974d6b628acddb41fbcb |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubestellar-prow
bot
added
the
approved
2 participants
Summary
This is a follow-on to #594, fixing remaining issues from that PR.
Update the release process to include E2E testing of the new release.
Fix organization and other issues in the documentation of E2E testing.
Fix the indenting in test/e2e/setup-kubeflex.sh.
Make test/e2e/setup-kubeflex.sh follow the instructions of the release being tested.
Describe input to test/e2e/setup-kubeflex.sh in
on.workflow_call, so that, e.g., a future PR could make the goreleaser workflow call the E2E test workflow on the release just made.When testing a release, install bin/kflex from that release (because the E2E test suite uses it).
Use the same Helm release name when testing a release as when testing local source, so that the debugging job steps for examining the release do not fail.
Related issue(s)
Fixes #