Skip to content

Conversation

@antedotee
Copy link
Contributor

@antedotee antedotee commented Nov 14, 2025

Now, the hide controls button will remain collapsed and only expand when someone clicks it. But when someone switches over to other things and then comes back, it will be collapsed by default.

I know, the issue was created keeping in mind the remember the state across navigation, but I intuitively think that if someone is switching over to other thing like grafana chart or lets say main, it will be more convenient to collapse the menu, and when he or she returns to the tree view, he can open it again.

Here is the supporting screenshot:
image

Fixes #2209

@kubestellar-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign btwshivam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
Copy link

Hi @antedotee. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@github-actions github-actions bot added frontend and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 0063cd9 to 01cb035 Compare November 14, 2025 14:58
@kubestellar-prow kubestellar-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2025
@antedotee antedotee changed the title fixed the sidebar issue fixed the hide controls issue when it automatically expands by default Nov 15, 2025
@kubestellar-prow kubestellar-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2025
@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 6dae59d to 9a2d3da Compare November 15, 2025 10:24
@antedotee
Copy link
Contributor Author

antedotee commented Nov 15, 2025

@btwshivam @clubanderson Please have a look.

@kubestellar-prow kubestellar-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2025
@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 150bb64 to 2114dba Compare November 16, 2025 16:00
@antedotee
Copy link
Contributor Author

Sorry for tagging, but can someone review this PR? @Arpit529Srivastava @btwshivam
Thanks and regards.

@Arpit529Srivastava
Copy link
Member

/ok-to-test

@kubestellar-prow kubestellar-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 17, 2025
@Per0x1de-1337
Copy link
Contributor

@antedotee Can you open another PR because there are irrelevant commits as per the number of lines to be changed.

Thanks!

Signed-off-by: antedotee <[email protected]>
Signed-off-by: antedotee <[email protected]>
Signed-off-by: antedotee <[email protected]>
Signed-off-by: antedotee <[email protected]>
@antedotee antedotee force-pushed the button-auto-pickup-fix branch from 2114dba to daf74fc Compare November 27, 2025 11:40
@btwshivam
Copy link
Contributor

@antedotee we are shifting this to right side #2261. Thank you!

@btwshivam btwshivam closed this Dec 6, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in KubeStellar UI Project Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Enhancement: Remember Sidebar State Across Navigation

4 participants