Update React to v19.2.1 #2273

katara-Jayprakash · 2025-12-08T17:17:47Z

Description

Related Issue

Fixes #2272

Changes Made

Updated ...
Refactored ...
Fixed ...
Added tests for ...

Checklist

Please ensure the following before submitting your PR:

I have reviewed the project's contribution guidelines.
I have written unit tests for the changes (if applicable).
I have updated the documentation (if applicable).
I have tested the changes locally and ensured they work as expected.
My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Additional Notes

Signed-off-by: katara-Jayprakash <[email protected]>

- Update react to 19.2.1 - Update react-dom to 19.2.1 - Update @types/react to 19.2.7 - Update @types/react-dom to 19.2.3 - Update @testing-library/react to 16.2.0 for React 19 compatibility

- Fix children prop types to accept ReactNode - Remove unnecessary PropsWithChildren wrapper - Ensure compatibility with React 19's stricter type checking Signed-off-by: katara-Jayprakash <[email protected]>

Signed-off-by: katara-Jayprakash <[email protected]>

kubestellar-prow · 2025-12-08T17:17:57Z

Hi @katara-Jayprakash. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

katara-Jayprakash · 2025-12-08T17:18:47Z

@btwshivam here we go sir

btwshivam · 2025-12-08T17:26:34Z

@katara-Jayprakash Run build locally and compile typescript.. then raise PR.. So many things are breaking You can check build checks

Copilot

Pull request overview

This PR upgrades React and related dependencies from version 18.3.1 to 19.2.1, along with updating @react-three/fiber, @react-three/drei, and associated TypeScript type definitions. The changes ensure compatibility with React 19's stricter type system and updated API patterns.

Key Changes

React and React DOM upgraded from 18.3.1 to 19.2.1
React Three Fiber upgraded from 8.13.6 to 9.4.2 and Drei from 9.80.0 to 10.7.7
TypeScript types updated to use stricter ref types (RefObject<T | null>), flexible children types (React.ReactNode), and explicit React imports for dynamic component rendering

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
frontend/package.json	Updated React core (19.2.1), React Three libraries, and TypeScript type definitions
frontend/package-lock.json	Updated dependency tree including React reconciler, scheduler, floating-ui, and three.js ecosystem packages
frontend/src/pages/Dashboard.tsx	Added explicit React import and converted dynamic icon rendering to React.createElement
frontend/src/components/wecs_details/tabs/LogsTab.tsx	Updated terminalRef type to RefObject<HTMLDivElement \| null> for React 19 compatibility
frontend/src/components/wecs_details/tabs/ExecTab.tsx	Updated execTerminalRef type to RefObject<HTMLDivElement \| null>
frontend/src/components/treeView/types.ts	Added NodeLabelProps interface and changed NodeData.label to React.ReactElement
frontend/src/components/treeView/TreeViewNodes.tsx	Updated type casting for accessing node label props with explicit NodeLabelProps type
frontend/src/components/treeView/TreeViewCanvas.tsx	Updated containerRef type to RefObject<HTMLDivElement \| null>
frontend/src/components/menu/Tooltip.tsx	Changed children prop type from React.ReactNode to optional React.ReactNode
frontend/src/components/login/globe/CosmicDust.tsx	Updated bufferAttribute to use args prop instead of array and itemSize props for React Three Fiber 9
frontend/src/components/its/ImportCluster/QuickConnectTab.tsx	Updated successAlertRef types to RefObject<HTMLDivElement \| null>
frontend/src/components/its/ClustersTable/dialogs/LabelEditDialog/LabelsList.tsx	Updated input ref types to RefObject<HTMLInputElement \| null>
frontend/src/components/common/ButtonTooltip.tsx	Changed children prop type to optional React.ReactNode
frontend/src/components/bindingPolicy/BPTable.tsx	Removed explicit JSX.Element return type annotation
frontend/src/components/WecsTopology.tsx	Reorganized interfaces with NodeLabelProps defined before NodeData
frontend/src/components/PublicRoute.tsx	Changed children type from JSX.Element to React.ReactNode
frontend/src/components/ProtectedRoute.tsx	Changed children type from JSX.Element to React.ReactNode
frontend/src/components/LanguageSwitcher.tsx	Wrapped ref callback in explicit block to comply with React 19 requirements
frontend/src/components/CommandPalette.tsx	Added explicit React import and converted icon rendering to React.createElement

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-08T17:29:57Z

frontend/package.json

    "nanoid": "^5.0.9",
    "puppeteer-core": "^24.1.1",
-    "react": "^18.3.1",
+    "react": "^19.2.1",


The PR title states "Updating react 1.19.1" but the actual version being updated to is 19.2.1. The title should be corrected to "Updating react 19.2.1" to accurately reflect the version change.

katara-Jayprakash · 2025-12-08T17:32:50Z

@katara-Jayprakash Run build locally and compile typescript.. then raise PR.. So many things are breaking You can check build checks

ok bhiaya ji ,

kunal-511 · 2025-12-08T17:53:25Z

frontend/package.json

    "react-chatbot-kit": "^2.2.2",
-    "react-dom": "^18.3.1",
+    "react-dom": "^19.2.1",
    "react-flow-renderer": "^10.3.17",


remove this dependency

Suggested change

"react-flow-renderer": "^10.3.17",

and I think after removing this re run the commands to update lock file

done i remove this and update the pr

Signed-off-by: katara-Jayprakash <[email protected]>

kunal-511 · 2025-12-08T18:36:55Z

/ok-to-test

kunal-511 · 2025-12-08T18:50:59Z

/lgtm
/approve

kubestellar-prow · 2025-12-08T18:51:03Z

LGTM label has been added.

Details

Git tree hash: b6822e36756dbc2671950ba2a4f7b8d46ff4c736

katara-Jayprakash · 2025-12-08T19:39:17Z

@kunal-511 @btwshivam any idea/hint why this ci is failing now?

kunal-511 · 2025-12-09T04:54:59Z

/retest

btwshivam · 2025-12-09T14:34:18Z

@alokdangre @Arpit529Srivastava playwright ci got huge time ig more then 60 min.. make it under 40-50 min max.. reduce wating time and flasky test

btwshivam · 2025-12-09T14:37:19Z

if nothing changeable then optimize the ci by running the test for only change made file.. show it pass quickly

btwshivam · 2025-12-09T14:43:35Z

you can do zero-risk optimizations like parallelization that could cut time in half. then adds smart test routing - only running relevant tests on PRs while keeping full coverage on dev branch. @alokdangre @Arpit529Srivastava make issue for it and work on it if possible

katara-Jayprakash · 2025-12-09T15:08:59Z

@btwshivam what should i do, to pass the ci, there is no error logs

btwshivam · 2025-12-09T16:41:27Z

@katara-Jayprakash I mentioned above.. we need to enable parallelization.. worker is 1 currently.. make it 4 and Add Test Sharding in CI to distributes load

btwshivam · 2025-12-09T21:07:37Z

@kunal approve the PR then we can squash merge

kunal-511 · 2025-12-10T12:35:54Z

/approve
/lgtm
cc : @btwshivam we can safely merge this one

kubestellar-prow · 2025-12-10T12:35:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunal-511

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kunal-511]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

katara-Jayprakash · 2025-12-10T12:56:48Z

/approve /lgtm cc : @btwshivam we can safely merge this one
@btwshivam can you review it last time and merge it, or is there anything i need to do?

kubestellar-prow · 2025-12-10T19:15:02Z

LGTM label has been added.

Details

Git tree hash: b0dee9c08d77b7c177014f1209e98ea162547435

clubanderson · 2025-12-10T19:16:15Z

/lgtm

approve

katara-Jayprakash added 5 commits December 8, 2025 20:45

update react in package.json

7a6c55c

Signed-off-by: katara-Jayprakash <[email protected]>

update typescript related stuff

7f57831

Signed-off-by: katara-Jayprakash <[email protected]>

chore: upgrade React from 18.1 to 19.2.1

2a09bae

- Update react to 19.2.1 - Update react-dom to 19.2.1 - Update @types/react to 19.2.7 - Update @types/react-dom to 19.2.3 - Update @testing-library/react to 16.2.0 for React 19 compatibility

fix: update ProtectedRoute and PublicRoute for React 19 compatibility

f6aa50a

- Fix children prop types to accept ReactNode - Remove unnecessary PropsWithChildren wrapper - Ensure compatibility with React 19's stricter type checking Signed-off-by: katara-Jayprakash <[email protected]>

fixing frontend files

4633e9c

Signed-off-by: katara-Jayprakash <[email protected]>

github-project-automation bot added this to KubeStellar UI Project Dec 8, 2025

github-project-automation bot moved this to In Progress in KubeStellar UI Project Dec 8, 2025

kubestellar-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2025

github-actions bot added the frontend label Dec 8, 2025

btwshivam requested review from Copilot and kunal-511 December 8, 2025 17:27

Copilot started reviewing on behalf of btwshivam December 8, 2025 17:27 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

kunal-511 previously requested changes Dec 8, 2025

View reviewed changes

kubestellar-prow bot assigned kunal-511 Dec 8, 2025

github-project-automation bot moved this from In Progress to Changes Required in KubeStellar UI Project Dec 8, 2025

kunal-511 changed the title ~~✨Updating react 1.19.1~~ Update React to v19.2.1 Dec 8, 2025

remove react-flow-renderer

98ca139

Signed-off-by: katara-Jayprakash <[email protected]>

kubestellar-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2025

kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2025

kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025

btwshivam approved these changes Dec 9, 2025

View reviewed changes

kubestellar-prow bot assigned btwshivam Dec 9, 2025

Merge branch 'dev' into updating-react-1.19.1

e9caf78

kubestellar-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025

kubestellar-prow bot requested review from btwshivam and kunal-511 December 10, 2025 19:13

clubanderson self-requested a review December 10, 2025 19:14

clubanderson approved these changes Dec 10, 2025

View reviewed changes

kubestellar-prow bot assigned clubanderson Dec 10, 2025

kubestellar-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025

clubanderson added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 10, 2025

btwshivam merged commit 5078460 into kubestellar:dev Dec 10, 2025
11 of 13 checks passed

github-project-automation bot moved this from Changes Required to Done in KubeStellar UI Project Dec 10, 2025

Update React to v19.2.1 #2273

Update React to v19.2.1 #2273

Uh oh!

Conversation

katara-Jayprakash commented Dec 8, 2025 • edited by kunal-511 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Changes Made

Checklist

Screenshots or Logs (if applicable)

Additional Notes

Uh oh!

kubestellar-prow bot commented Dec 8, 2025

Uh oh!

katara-Jayprakash commented Dec 8, 2025

Uh oh!

btwshivam commented Dec 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

katara-Jayprakash commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kunal-511 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kunal-511 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

katara-Jayprakash Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kunal-511 commented Dec 8, 2025

Uh oh!

kunal-511 commented Dec 8, 2025

Uh oh!

kubestellar-prow bot commented Dec 8, 2025

Uh oh!

katara-Jayprakash commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kunal-511 commented Dec 9, 2025

Uh oh!

btwshivam commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

btwshivam commented Dec 9, 2025

Uh oh!

btwshivam commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katara-Jayprakash commented Dec 9, 2025

Uh oh!

btwshivam commented Dec 9, 2025

Uh oh!

btwshivam commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kunal-511 commented Dec 10, 2025

Uh oh!

kubestellar-prow bot commented Dec 10, 2025

Uh oh!

katara-Jayprakash commented Dec 10, 2025

Uh oh!

kubestellar-prow bot commented Dec 10, 2025

Uh oh!

clubanderson commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

katara-Jayprakash commented Dec 8, 2025 •

edited by kunal-511

Loading

katara-Jayprakash commented Dec 8, 2025 •

edited

Loading

katara-Jayprakash commented Dec 8, 2025 •

edited

Loading

btwshivam commented Dec 9, 2025 •

edited

Loading

btwshivam commented Dec 9, 2025 •

edited

Loading

btwshivam commented Dec 9, 2025 •

edited

Loading