-
Notifications
You must be signed in to change notification settings - Fork 228
📖 Fix WECS panel size inconsistency #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rahulshendre <[email protected]>
|
👋 Hello! @rahulshendre Welcome to the Kubestellar. Thank you for submitting your first Pull Request to KubeStellar. We are delighted to have you in our Universe! |
|
Hi @rahulshendre. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rahulshendre include a video or images showing the changes before and after. |
|
sure @oksaumya ui_inconsistency_issue.mp4After (fixed) ui_inconsistency_solved.mov |
|
/ok-to-test |
kunal-511
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulshendre Please run
npm run format
and then push your changes
Signed-off-by: rahulshendre <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunal-511 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 2b2a1f07fea49a8f57302c8077b5767ae4a9666e |
Fixes the issue where the WECS details panel did not expand fully compared to staged workloads, it now does, keeping the UI consistent.
Fixes #2274