Skip to content

fix: Missing link between namespace and child resources in Remote-Cluster Treeview #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ANAMASGARD wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

fix: Missing link between namespace and child resources in Remote-Cluster Treeview #2310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/WecsTopology.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@
}))
);
}
}, [edgeType]);

Check warning on line 608 in frontend/src/components/WecsTopology.tsx

View workflow job for this annotation

GitHub Actions / Frontend Checks 

React Hook useEffect has a missing dependency: 'edges.length'. Either include it or remove the dependency array

useEffect(() => {
const timer = setTimeout(() => {
Expand Down Expand Up @@ -831,7 +831,7 @@
if (!cachedNode) nodeCache.current.set(id, node);
newNodes.push(node);

if (parent && stateRef.current.isExpanded) {
if (parent) {
const uniqueSuffix = resourceData?.metadata?.uid || edgeIdCounter.current++;
const edgeId = `edge-${parent}-${id}-${uniqueSuffix}`;
const edge = {
Expand Down Expand Up @@ -1292,7 +1292,7 @@
prevNodes.current = layoutedNodes;
setIsTransforming(false);
},
[createNode, fetchAllClusterTimestamps]

Check warning on line 1295 in frontend/src/components/WecsTopology.tsx

View workflow job for this annotation

GitHub Actions / Frontend Checks 

React Hook useCallback has missing dependencies: 'edges' and 'nodes'. Either include them or remove the dependency array
);

// Memoize the data processing to avoid unnecessary re-renders
Expand Down
Loading