Skip to content

Add logic to create HTTP Listener with new annotations. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add logic to create HTTP Listener with new annotations. #4

wants to merge 1 commit into from

Conversation

cookingcodewithme
Copy link

I have added a logic which can create HTTP listener instead of TCP listener with the following annotations.

apiVersion: v1
kind: Service
metadata:
	annotations:
		aliyun.archon.kubeup.com/bandwidth: "1"
		aliyun.archon.kubeup.com/load-balancer-backend-protocol: "http"
		aliyun.archon.kubeup.com/load-balancer-health-check: "true"

ledzep2
ledzep2 reviewed Sep 18, 2017
View reviewed changes
Copy link
Collaborator

@ledzep2 ledzep2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally http loadbalancer should be provided by Ingress controller. It's a workaround as we don't have Ingress support for now. Would love a second opinion. @adieu

And, can you fix the inconsistent format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledzep2 ledzep2 ledzep2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cookingcodewithme @ledzep2