MTV-3225 Fix links in MTV repo #754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHoch
force-pushed
the
MTV-3225_links_with_attributes
branch
3 times, most recently
from
0bd8a42 to
9370223
Compare
RichardHoch
force-pushed
the
MTV-3225_links_with_attributes
branch
from
05dae8e to
50d3e0c
Compare
|
@anarnold97 Plesea review this PR. Thanks. |
nunzy1
reviewed
Sep 10, 2025
nunzy1
reviewed
Sep 10, 2025
anarnold97
reviewed
Sep 10, 2025
| ** Optional: To configure another {ocp-short} network in the {ocp-short} web console, click *Networking > NetworkAttachmentDefinitions*. | ||
| + | ||
| To learn more about the different types of networks {ocp-short} supports, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/{ocp-version}/html-single/networking/index#additional-networks-provided_understanding-multiple-networks[Additional Networks in OpenShift Container Platform]. | ||
| To learn more about the different types of networks {ocp-short} supports, see {ocp-doc}/multiple_networks/understanding-multiple-networks#additional-networks-provided_understanding-multiple-networks[Secondary Networks in OpenShift Container Platform]. |
There was a problem hiding this comment.
Suggested change
| To learn more about the different types of networks {ocp-short} supports, see {ocp-doc}/multiple_networks/understanding-multiple-networks#additional-networks-provided_understanding-multiple-networks[Secondary Networks in OpenShift Container Platform]. | |
| To learn more about the different types of networks {ocp-short} supports, see {ocp-doc}/multiple_networks/understanding-multiple-networks#additional-networks-provided_understanding-multiple-networks[Secondary Networks in OpenShift Container Platform]. |
might be worth adding an new attribute for OpenShift Container Platform as it is used 35 times in MTV docs and will be more heavily used with OCP 4.20. WDYT?
There was a problem hiding this comment.
@anarnold97 Probably a good idea. A Jira for the MTV repo? Maybe after 2.10 is GA?
anarnold97
reviewed
Sep 10, 2025
anarnold97
reviewed
Sep 10, 2025
RichardHoch
force-pushed
the
MTV-3225_links_with_attributes
branch
3 times, most recently
from
b25dea3 to
49d048d
Compare
|
@anarnold97 I checked the links -- they were fine, but I did fix a few captions to make them exact. Only one worth mentioning is line 28 of creating-vddk-image.adoc. The link always led to the section named "Configuring the registry for bare metal" but the display text didn't specify "bare metal" before. Aside from that, nothing else to report. |
RichardHoch
force-pushed
the
MTV-3225_links_with_attributes
branch
from
de2c727 to
15b67f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTV 2.9.4
Resolves https://issues.redhat.com/browse/MTV-3225 by changing links that have an attribute in them.
Preview: https://file.corp.redhat.com/rhoch/MTV-3225_links_with_attributes/html-single/ [complete user guide]