-
Couldn't load subscription status.
- Fork 31
add openSUSE Leap 16 handling #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @dirkmueller. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looking great except for a few comments.
| common.DefaultInstancetypeEnv: "u1.medium", | ||
| common.DefaultPreferenceEnv: "opensuse.leap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these could work on aarch64 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preference set a minimum of 1 cpu and 2GiB. I'm not able to find the minimum requirements for aarch64. @dirkmueller, could you please check if arm version meets this minimum hardware requirements too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is officially documented anywhere, but I think that would work. I've started very minimal VMs with that configuration.
|
/release-note-none |
|
@dirkmueller ping |
Signed-off-by: Dirk Müller <[email protected]>
thanks for the reminder, this fell off the list |
Thanks to you for your contribution! |
|
@dirkmueller: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
openSUSE Leap has recently released it's newest stable release 16.0, which has a slightly different url layout.