Skip to content

Conversation

@dirkmueller
Copy link

What this PR does / why we need it:

openSUSE Leap has recently released it's newest stable release 16.0, which has a slightly different url layout.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 15, 2025
@kubevirt-bot
Copy link
Contributor

Hi @dirkmueller. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lyarwood for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 15, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looking great except for a few comments.

Comment on lines +33 to +34
common.DefaultInstancetypeEnv: "u1.medium",
common.DefaultPreferenceEnv: "opensuse.leap",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these could work on aarch64 too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preference set a minimum of 1 cpu and 2GiB. I'm not able to find the minimum requirements for aarch64. @dirkmueller, could you please check if arm version meets this minimum hardware requirements too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is officially documented anywhere, but I think that would work. I've started very minimal VMs with that configuration.

@0xFelix
Copy link
Member

0xFelix commented Oct 16, 2025

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2025
@jcanocan
Copy link
Contributor

@dirkmueller ping

Signed-off-by: Dirk Müller <[email protected]>
@dirkmueller
Copy link
Author

@dirkmueller ping

thanks for the reminder, this fell off the list

@jcanocan
Copy link
Contributor

@dirkmueller ping

thanks for the reminder, this fell off the list

Thanks to you for your contribution!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@kubevirt-bot
Copy link
Contributor

@dirkmueller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerdisks-pipeline-centos-stream-9-s390x 466c25d link true /test pull-containerdisks-pipeline-centos-stream-9-s390x
pull-containerdisks-test 466c25d link true /test pull-containerdisks-test
pull-containerdisks-pipeline-opensuse-leap 466c25d link true /test pull-containerdisks-pipeline-opensuse-leap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants