Skip to content

Conversation

sradco
Copy link

@sradco sradco commented Aug 21, 2025

What this PR does / why we need it:
Stop use the deprecated github.com/machadovilaca/operator-observability package. Use the up-to-date
github.com/rhobs/operator-observability-toolkit package instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #https://issues.redhat.com/browse/CNV-56710

Special notes for your reviewer:

Release note:

NONE

Stop use the deprecated github.com/machadovilaca/operator-observability
package. Use the up-to-date
github.com/rhobs/operator-observability-toolkit package instead.

Signed-off-by: Shirly Radco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 21, 2025
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link

@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-hostpath-provisioner-k8s-e2e-storage f2f58b4 link true /test pull-hostpath-provisioner-k8s-e2e-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sradco
Copy link
Author

sradco commented Aug 21, 2025

@awels @avlitman @machadovilaca please review this PR

@awels
Copy link
Member

awels commented Sep 17, 2025

@sradco I think this needs a rebase now.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025
@kubevirt-bot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants