Skip to content

fix: consume binance daily reference prices - #1332

Merged
ibruno merged 3 commits into
mainfrom
fix/binance-daily-reference-prices
Jul 22, 2026
Merged

fix: consume binance daily reference prices#1332
ibruno merged 3 commits into
mainfrom
fix/binance-daily-reference-prices

Conversation

@ibruno

@ibruno ibruno commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Consume Binance daily reference prices and enforce the canonical daily close for Binance 1d. This prevents premature closing prices in charts and API responses by hiding pre-close data until the exact close is available, even while the snapshot is pending.

  • Bug Fixes
    • API: added binance and pyth; for Binance 1d, the closing row must match the exact end timestamp.
    • UI: for closed Binance-style daily crypto, do not render pre-close points or use fallback/rendered price; header shows final price in foreground while keeping the delta color.
    • Hook/Logic: classify daily crypto series as requiring a canonical Binance close; expose referenceSnapshotStatus (loading/ready/unavailable); poll for the close after event end (~65s delay, every 10s, up to 5 minutes).
    • Docs/Types: OpenAPI and TS types updated to include binance and pyth.

Written for commit 0c4a972. Summary will update on new commits.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant