fix: consume binance daily reference prices - #1332
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Consume Binance daily reference prices and enforce the canonical daily close for Binance
1d. This prevents premature closing prices in charts and API responses by hiding pre-close data until the exact close is available, even while the snapshot is pending.binanceandpyth; for Binance1d, the closing row must match the exact end timestamp.referenceSnapshotStatus(loading/ready/unavailable); poll for the close after event end (~65s delay, every 10s, up to 5 minutes).binanceandpyth.Written for commit 0c4a972. Summary will update on new commits.