Skip to content

feat: update order utils to v2#1

Merged
ibruno merged 5 commits into
mainfrom
fix/bump-deps-py-order-utils
May 24, 2026
Merged

feat: update order utils to v2#1
ibruno merged 5 commits into
mainfrom
fix/bump-deps-py-order-utils

Conversation

@ibruno

@ibruno ibruno commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Upgrade py_order_utils to Order V2 with EIP‑712 domain version "2" and a new order schema. Updates signatures/hashes and CI (Ubuntu 24.04 with actions/checkout@v6 and actions/setup-python@v6).

  • New Features

    • EIP‑712 domain version "2".
    • V2 fields: millisecond timestamp (auto-filled), metadata/builder as bytes32 defaulting to ZERO_BYTES32. Removed taker, nonce, feeRateBps; expiration moved to SignedOrder.expiration.
    • Updated abi/Exchange.json, test addresses, and expected struct hashes/signatures.
    • Version bumps: package 0.3.6, kuest-py-eip712-structs 0.0.4.
  • Migration

    • Do not pass taker, nonce, feeRateBps, or expiration in OrderData. Set timestamp (ms) or let the builder auto-fill; metadata and builder are optional.
    • Read expiration from SignedOrder.expiration. Verify EIP‑712 with domain version "2" and the new struct; expect new hashes/signatures.

Written for commit 55b10a2. Summary will update on new commits. Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="requirements.txt">

<violation number="1" location="requirements.txt:3">
P0: Dependency `kuest-py-eip712-structs==0.0.4` does not appear to be published on PyPI, which will cause `pip install` to fail with a version-not-found error.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread requirements.txt
eth-account===0.13.0
eth-utils===4.1.1
kuest-py-eip712-structs==0.0.3
kuest-py-eip712-structs==0.0.4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Dependency kuest-py-eip712-structs==0.0.4 does not appear to be published on PyPI, which will cause pip install to fail with a version-not-found error.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At requirements.txt, line 3:

<comment>Dependency `kuest-py-eip712-structs==0.0.4` does not appear to be published on PyPI, which will cause `pip install` to fail with a version-not-found error.</comment>

<file context>
@@ -1,4 +1,4 @@
 eth-account===0.13.0
 eth-utils===4.1.1
-kuest-py-eip712-structs==0.0.3
+kuest-py-eip712-structs==0.0.4
 pytest==8.2.2
</file context>

@ibruno
ibruno merged commit 8f01468 into main May 24, 2026
2 checks passed
@ibruno
ibruno deleted the fix/bump-deps-py-order-utils branch May 24, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant