feat: update order utils to v2#1
Merged
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="requirements.txt">
<violation number="1" location="requirements.txt:3">
P0: Dependency `kuest-py-eip712-structs==0.0.4` does not appear to be published on PyPI, which will cause `pip install` to fail with a version-not-found error.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| eth-account===0.13.0 | ||
| eth-utils===4.1.1 | ||
| kuest-py-eip712-structs==0.0.3 | ||
| kuest-py-eip712-structs==0.0.4 |
There was a problem hiding this comment.
P0: Dependency kuest-py-eip712-structs==0.0.4 does not appear to be published on PyPI, which will cause pip install to fail with a version-not-found error.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At requirements.txt, line 3:
<comment>Dependency `kuest-py-eip712-structs==0.0.4` does not appear to be published on PyPI, which will cause `pip install` to fail with a version-not-found error.</comment>
<file context>
@@ -1,4 +1,4 @@
eth-account===0.13.0
eth-utils===4.1.1
-kuest-py-eip712-structs==0.0.3
+kuest-py-eip712-structs==0.0.4
pytest==8.2.2
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgrade
py_order_utilsto Order V2 with EIP‑712 domain version "2" and a new order schema. Updates signatures/hashes and CI (Ubuntu 24.04 withactions/checkout@v6andactions/setup-python@v6).New Features
timestamp(auto-filled),metadata/builderas bytes32 defaulting toZERO_BYTES32. Removedtaker,nonce,feeRateBps;expirationmoved toSignedOrder.expiration.abi/Exchange.json, test addresses, and expected struct hashes/signatures.0.3.6,kuest-py-eip712-structs0.0.4.Migration
taker,nonce,feeRateBps, orexpirationinOrderData. Settimestamp(ms) or let the builder auto-fill;metadataandbuilderare optional.expirationfromSignedOrder.expiration. Verify EIP‑712 with domain version "2" and the new struct; expect new hashes/signatures.Written for commit 55b10a2. Summary will update on new commits. Review in cubic