Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page #12

Closed
wants to merge 8 commits into from
Closed

404 page #12

wants to merge 8 commits into from

Conversation

yousefkadah
Copy link
Contributor

This PR adds a custom 404 page to the Kunafa Plus Dashboard.
The page provides a user-friendly error message.

It includes:
A visually appealing design that matches the app's theme.
A clear message informing users that the page is not found.
A button to navigate back to the home page for better UX.
A button to open new issue in the project.
Let me know if you need modifications! 🚀

- Created a new `KunafaLogo` component for the app logo.
- Updated existing files to use the `KunafaLogo` component.
- Improved maintainability by centralizing the logo.
Copy link
Member

@mjamal-dev mjamal-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Although you have pending changes that are shared across multiple PRs #8
This could cause a conflict on one PR when either of those PRs gets merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is from pr #8 and still pending merge. If you could remove this change from this pr for separation of concerns.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is from pr #8 and still pending merge. If you could remove this change from this pr for separation of concerns.

@mjamal-dev
Copy link
Member

Sorry Mr. Yousef, due to the complications, this PR will be closed. Kindly make a new PR that proposes to fix exactly what the title says, which is 404 page. On the contrary, your other changes 1d765de in PR #8 have been merged already.

Be safe, and always be creative!

@mjamal-dev mjamal-dev closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants