-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [DEVEX-227] Getting state from events and running busines logic #334
Draft
oskardudycz
wants to merge
26
commits into
DEVEX-185-Rebranding
Choose a base branch
from
DEVEX-227-GettingStateAndMakingDecisions
base: DEVEX-185-Rebranding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: [DEVEX-227] Getting state from events and running busines logic #334
oskardudycz
wants to merge
26
commits into
DEVEX-185-Rebranding
from
DEVEX-227-GettingStateAndMakingDecisions
+2,624
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsions They're redundant as most of them should be handled by the ReadStreamOptions. Expected checks can be made on the append side and also passed to decide options to only read as many events as needed.
…tween StateBuilder and AsyncStateBuilder
…g and decision making
Also simplified the StateBuilder abstraction to reduce the number of classes. Reshaped Decider implementation, now AsyncDecider uses raw code and regular Decider wraps around it.
Now AsyncEnumerable part will always assume that it gets the exact initial state, it needs to be read first either from state builder or snapshot. That makes it explicit on the responsibilities.
…re to a dedicated file
…e overloads to extension methods
d71db29
to
a84083a
Compare
… extension method for regular events
Made also other smaller improvements like: - removing event from state store interface, - made both StateStore and AggregateStore method virtual, - decoupled Decider from AsyncDecider moving the mapping method to extension classes.
… of the single state That gives possibility to cache multiple single stream projection states instead of rolling always a single one
f69a63a
to
dd8cf4c
Compare
8c7d67a
to
7b1b13c
Compare
7b1b13c
to
0a5bc23
Compare
…ggregate Store Also split the Decider information and Decision processing
86c22ab
to
a8a4f4a
Compare
a8a4f4a
to
d2f9d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP