Skip to content

Allow specifying custom KurrentDB docker images in dispatch tests #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,25 @@ on:
workflow_call:
inputs:
kurrentdb-tag:
description: The docker tag to use. If kurrentdb-image is empty, the action will use the values in the KURRENTDB_DOCKER_IMAGES variable (ci, lts, previous-lts).
required: true
type: string
kurrentdb-image:
description: The docker image to use. Leave this empty to use the image in the KURRENTDB_DOCKER_IMAGES variable.
required: false
type: string
kurrentdb-registry:
description: The docker registry to use. Leave this empty to use the registry in the KURRENTDB_DOCKER_IMAGES variable.
required: false
type: string
test:
description: Which test to run.
required: true
type: string
env:
KURRENTDB_TAG: ${{ fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].tag}}
KURRENTDB_IMAGE: ${{ fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].image}}
KURRENTDB_REGISTRY: ${{ fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].registry}}
KURRENTDB_TAG: ${{ inputs.kurrentdb-image != '' && inputs.kurrentdb-tag || fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].tag }}
KURRENTDB_IMAGE: ${{ inputs.kurrentdb-image || fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].image }}
KURRENTDB_REGISTRY: ${{ inputs.kurrentdb-registry || fromJSON(vars.KURRENTDB_DOCKER_IMAGES)[inputs.kurrentdb-tag].registry }}
jobs:
test:
timeout-minutes: 20
Expand Down
18 changes: 12 additions & 6 deletions .github/workflows/dispatch-ee.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ on:
workflow_dispatch:
inputs:
kurrentdb-tag:
description: "KurrentDB tag"
description: "The KurrentDB docker tag to use. If kurrentdb-image is empty, the action will use the values in the KURRENTDB_DOCKER_IMAGES variable (ci, lts, previous-lts)."
required: true
type: choice
options:
- ci
- lts
- previous-lts
type: string
kurrentdb-image:
description: "The KurrentDB docker image to test against. Leave this empty to use the image in the KURRENTDB_DOCKER_IMAGES variable"
required: false
type: string
kurrentdb-registry:
description: "The docker registry containing the KurrentDB docker image. Leave this empty to use the registry in the KURRENTDB_DOCKER_IMAGES variable."
required: false
type: string
jobs:
test:
uses: ./.github/workflows/base.yml
Expand All @@ -21,5 +25,7 @@ jobs:
name: Test (${{ inputs.kurrentdb-tag }})
with:
kurrentdb-tag: ${{ inputs.kurrentdb-tag }}
kurrentdb-image: ${{ inputs.kurrentdb-image }}
kurrentdb-registry: ${{ inputs.kurrentdb-registry }}
test: ${{ matrix.test }}
secrets: inherit
Loading