Skip to content

fix compilation errors #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix compilation errors #145

merged 2 commits into from
Mar 20, 2025

Conversation

xhyf77
Copy link
Collaborator

@xhyf77 xhyf77 commented Mar 16, 2025

Compilation fails on Debian 12 (Bookworm) due to libgrpc29 version.

xhy@debian12:~/Mooncake/build$ make -j
[ 89%] Linking CXX executable client_integration_test
[ 90%] Linking CXX executable mooncake_master
[ 95%] Built target mooncake_vllm_adaptor
/usr/bin/ld: libcache_allocator.a(master.grpc.pb.cpp.o): undefined reference to symbol 'gpr_log'
/usr/bin/ld: /lib/x86_64-linux-gnu/libgpr.so.29: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [mooncake-store/src/CMakeFiles/mooncake_master.dir/build.make:103:mooncake-store/src/mooncake_master] 错误 1
make[1]: *** [CMakeFiles/Makefile2:800:mooncake-store/src/CMakeFiles/mooncake_master.dir/all] 错误 2
make[1]: *** 正在等待未完成的任务....
/usr/bin/ld: ../src/libcache_allocator.a(master.grpc.pb.cpp.o): undefined reference to symbol 'gpr_log'
/usr/bin/ld: /lib/x86_64-linux-gnu/libgpr.so.29: error adding symbols: DSO missing from command line
/usr/bin/ld: ../src/libcache_allocator.a(master.grpc.pb.cpp.o): undefined reference to symbol 'gpr_log'
/usr/bin/ld: /lib/x86_64-linux-gnu/libgpr.so.29: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [mooncake-store/tests/CMakeFiles/client_integration_test.dir/build.make:103:mooncake-store/tests/client_integration_test] 错误 1
make[1]: *** [CMakeFiles/Makefile2:922:mooncake-store/tests/CMakeFiles/client_integration_test.dir/all] 错误 2
collect2: error: ld returned 1 exit status
make[2]: *** [mooncake-store/tests/CMakeFiles/stress_workload_test.dir/build.make:103:mooncake-store/tests/stress_workload_test] 错误 1
make[1]: *** [CMakeFiles/Makefile2:954:mooncake-store/tests/CMakeFiles/stress_workload_test.dir/all] 错误 2
make: *** [Makefile:146:all] 错误 2

xhy@debian12:~/Mooncake$ dpkg -l|grep grpc
ii  libgrpc++-dev:amd64                           1.51.1-3+b1                         amd64        high performance general RPC framework (development)
ii  libgrpc++1.51:amd64                           1.51.1-3+b1                         amd64        high performance general RPC framework
ii  libgrpc-dev:amd64                             1.51.1-3+b1                         amd64        high performance general RPC framework (development)
ii  libgrpc29:amd64                               1.51.1-3+b1                         amd64        high performance general RPC framework
ii  protobuf-compiler-grpc                        1.51.1-3+b1                         amd64        high performance general RPC framework - protobuf plugin

can be resolved by this commit

@stmatengss
Copy link
Collaborator

image
Does your testing environment differ from our CI environment? Perhaps you're using a different gRPC version.

@xhyf77
Copy link
Collaborator Author

xhyf77 commented Mar 16, 2025

Does your testing environment differ from our CI environment? Perhaps you're using a different gRPC version.

Yes, perhaps downloading grpc through apt get in a CI environment does not automatically generate the corresponding configuration

@xhyf77 xhyf77 closed this Mar 16, 2025
@xhyf77 xhyf77 reopened this Mar 16, 2025
@alogfans alogfans merged commit 16fc186 into kvcache-ai:main Mar 20, 2025
1 check passed
@xhyf77 xhyf77 deleted the fix-compilation branch April 3, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants