[FEATURE] Support mounting multiple segments under the same segment_name #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
based on #146 |
|
According to our previous design, a segment can be either
So, we assume a TransferEngine instance has ONLY ONE segment. However we can register multiple non-contigous buffers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported mounting multiple segments for the same client.
Taking it a step further, we might consider modifying the segment management interface on the client side, such as removing the
segment_nameparameter from the interface (since the segment name is fixed once the client is inited).Going even further, the client should ideally be stateless, and perhaps
MountSegmentshould return a handle whose ownership is managed by the user.To keep this PR concise, the discussions will not be implemented in this PR.