Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 1.19.3 and fix some error (not working yet) #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fedetrifo06
Copy link

I updated the mod to Minecraft 1.19.3 but i can't compile it for some errors.

Anyone can fix it?

@fedetrifo06 fedetrifo06 mentioned this pull request Jan 15, 2023
@mrjasonn mrjasonn mentioned this pull request Jan 26, 2023
@Rektroth
Copy link

Rektroth commented Jan 27, 2023

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

@Rektroth
Copy link

Rektroth commented Jan 30, 2023

As it turns out, the preview versions of 1.19.3 OptiFine that are presently available do not currently feature colormapping, likely for this exact reason. Based on what I've seen trying to get it working, it's my opinion that colormapping will have to be completely overhauled.

@fedetrifo06
Copy link
Author

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

I know, but this is a start

@extremepayne
Copy link

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

@Rektroth
Copy link

Rektroth commented Feb 3, 2023

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

@mstreurman
Copy link

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

@Rektroth
Copy link

Rektroth commented Apr 2, 2023

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

I haven't actually looked further yet.

Honestly, given some of what we've seen in today's April Fools snapshot, combined with the fact that we have seen Mojang add April Fools features to the game before (see Coal Block snd Stained Glass), I'm hopeful custom colormapping in the vanilla game is coming in the near future. 🫰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants