New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for fix of #6 #130

Open

velnias75 wants to merge 1 commit into kvverti:master from velnias75:LightingGUIFix

velnias75 commented Feb 9, 2023

Hi,

I got the GUI to display in correct colors. But I don't fully understand your (or Minecraft's) flickering code.

Essentially it applies the custom lighting only to the world render phase and applies afterwards Minecraft's own lighting.

To test, you can use this tiny test resourcepack: lightmap-bug.zip

Go into the Nether:

Without my PR all GUI (inventory, texts, etc.) will get yellowish and will stay even after returning to the main menu.
With my PR the custom lightmap gets applied, but all GUI including the main menu stay in correct colors.


          Proposal for fix of kvverti#6

1ab66ca

velnias75 marked this pull request as ready for review

February 9, 2023 01:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet