Repository navigation
Conversation
cubicj
left a comment
There was a problem hiding this comment.
I have #1487 open since June for the same missing label, adding longPressToPopupEditor to en.ts and ko.ts. The two current heads merge without a conflict, so merging both leaves the key twice in each file and TypeScript fails with TS1117. You're right that the English key was dropped in the cbf2d1d merge.
#1487 doesn't touch the settings order, though. Block, Long Press, Drag has been the order since e03c389, so moving Drag above Block isn't part of the restore. Was that move intentional?
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a3ecde8 to
71526fb
Compare
cubicj
left a comment
There was a problem hiding this comment.
I went through 71526fb on this. Your read of the history checks out. f8d9509 added the long press item as a copy of the drag entry right after it, and e03c389 then renamed the original drag entry instead of the copy, which is how long press ended up between the two partial edit options. The drag entry moves unchanged and these settings keep the same bindKey values, so only the display order changes and saved settings are not affected. With the label lines dropped, this and #1487 merge cleanly without the duplicate key.
Approving — thanks for the update!
PR Checklist
Summary
Moves the drag partial edit option next to the block partial edit option in accessibility settings, so the long press popup editor option no longer sits between them.
Related Issues
None.
Changes
The label was removed in cbf2d1d, probably by a merge conflict.
This PR#1487 restores the label.Impact
None.