Skip to content

fix: A11y long press editor option between block/drag partial edit options - #1650

Open
enzi221 wants to merge 1 commit into
kwaroran:mainfrom
enzi221:fix/long-press-popup-editor-label
Open

enzi221 wants to merge 1 commit into
kwaroran:mainfrom
enzi221:fix/long-press-popup-editor-label

Conversation

@enzi221

@enzi221 enzi221 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?
  • If your PR is highly AI generated[^2], check the following:
    • Have you understood what the code does?
    • Have you cleaned up any unnecessary or redundant code?
    • Is it not a huge change?
      • We currently do not accept highly AI generated PRs that are large changes.

Summary

Moves the drag partial edit option next to the block partial edit option in accessibility settings, so the long press popup editor option no longer sits between them.

image

Related Issues

None.

Changes

The label was removed in cbf2d1d, probably by a merge conflict. This PR #1487 restores the label.

Impact

None.

@cubicj cubicj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have #1487 open since June for the same missing label, adding longPressToPopupEditor to en.ts and ko.ts. The two current heads merge without a conflict, so merging both leaves the key twice in each file and TypeScript fails with TS1117. You're right that the English key was dropped in the cbf2d1d merge.

#1487 doesn't touch the settings order, though. Block, Long Press, Drag has been the order since e03c389, so moving Drag above Block isn't part of the restore. Was that move intentional?

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@enzi221
enzi221 force-pushed the fix/long-press-popup-editor-label branch from a3ecde8 to 71526fb Compare October 10, 2026 11:57
@enzi221

enzi221 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

@cubicj Yes, I believe the order change was also made by mistake, see f8d9509 then e03c389.

I didn't know of #1487, thank you. Changing this PR to contain only the order fix.

@enzi221 enzi221 changed the title fix: Restore long press editor label fix: A11y long press editor option between block/drag partial edit options Oct 10, 2026

@cubicj cubicj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through 71526fb on this. Your read of the history checks out. f8d9509 added the long press item as a copy of the drag entry right after it, and e03c389 then renamed the original drag entry instead of the copy, which is how long press ended up between the two partial edit options. The drag entry moves unchanged and these settings keep the same bindKey values, so only the display order changes and saved settings are not affected. With the label lines dropped, this and #1487 merge cleanly without the duplicate key.

Approving — thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants