Repository navigation
Conversation
3 tasks done
enzi221
force-pushed
the
feat/inlay-date-and-source
branch
2 times, most recently
from
February 16, 2026 12:44
6423879 to
ea5f2f2
Compare
Owner
|
While adding the creation time could be beneficial in some cases, I think the disadvantages outweigh the advantages. The size of objects, modules and characters with many assets would increase significantly, which could cause some lag in the serialisation process. |
kwaroran
added a commit
that referenced
this pull request
Feb 20, 2026
## PR Checklist
- Required Checks
- [x] Have you added type definitions?
- [x] Have you tested your changes?
- [x] Have you checked that it won't break any existing features?
## Summary
`src/ts/parser.svelte` -> `src/ts/parser/parser.svelte`
I hope to change it into `chatParser` or something, not just `parser`,
since the function itself is named `risuChatParser`. Maybe later.
## Related Issues
None.
## Changes
Please refer to the Summary.
Absolutely no other changes. A simple drag & drop of `parser.svelte.ts`
was all I did; everything else are import path changes.
## Impact
None.
## Additional Notes
Inlay test now mocks an nonexistent file. It will get a fix with #1259.
Contributor
Author
|
@kwaroran Fair enough, how about opt-in then? In "Other Bots > Image Generation" or "Advanced Settings". Inlay key is fully randomized so current explorer sorted in the random key is not so useful alone. |
|
Or perhaps even place it where you have to toggle show unrecommended settings to see it? |
3 tasks done
enzi221
force-pushed
the
feat/inlay-date-and-source
branch
2 times, most recently
from
March 2, 2026 12:53
dc70b29 to
3eecd57
Compare
enzi221
force-pushed
the
feat/inlay-date-and-source
branch
from
March 7, 2026 15:09
3eecd57 to
f52c734
Compare
kwaroran
added a commit
that referenced
this pull request
Mar 28, 2026
## PR Checklist
- Required Checks
- [x] Have you added type definitions?
- [x] Have you tested your changes?
- [x] Have you checked that it won't break any existing features?
## Summary
Splitted from #1259. This PR only contains the test fixing part.
## Related Issues
None.
## Changes
Module mocks fixed.
## Impact
None.
cubicj
approved these changes
Jul 4, 2026
cubicj
left a comment
cubicj
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I don't think the extra created field meaningfully changes the storage cost here, since inlay assets already live in their own localforage store and the field stays optional for existing assets.
Check, tests, and build pass locally.
Approving — thanks for the contribution!
enzi221
force-pushed
the
feat/inlay-date-and-source
branch
from
August 22, 2026 09:06
f52c734 to
b03cd1d
Compare
enzi221
force-pushed
the
feat/inlay-date-and-source
branch
from
August 30, 2026 15:59
b03cd1d to
2501f86
Compare
yor42
pushed a commit
to yor42/RisuTanium
that referenced
this pull request
Sep 21, 2026
## PR Checklist
- Required Checks
- [x] Have you added type definitions?
- [x] Have you tested your changes?
- [x] Have you checked that it won't break any existing features?
## Summary
`src/ts/parser.svelte` -> `src/ts/parser/parser.svelte`
I hope to change it into `chatParser` or something, not just `parser`,
since the function itself is named `risuChatParser`. Maybe later.
## Related Issues
None.
## Changes
Please refer to the Summary.
Absolutely no other changes. A simple drag & drop of `parser.svelte.ts`
was all I did; everything else are import path changes.
## Impact
None.
## Additional Notes
Inlay test now mocks an nonexistent file. It will get a fix with kwaroran#1259.
yor42
pushed a commit
to yor42/RisuTanium
that referenced
this pull request
Sep 21, 2026
## PR Checklist
- Required Checks
- [x] Have you added type definitions?
- [x] Have you tested your changes?
- [x] Have you checked that it won't break any existing features?
## Summary
Splitted from kwaroran#1259. This PR only contains the test fixing part.
## Related Issues
None.
## Changes
Module mocks fixed.
## Impact
None.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Records inlay asset creation/attachment timestamps for future utilization. Simply displays them in the explorer for now.
Related Issues
None.
Changes
Both
postInlayAsset()andwriteInlayImage()recordsDate.now()into the storage.Also fixes inlay tests as #1250 invalidated the mocking.
Impact
None;
createdfield is optional.Additional Notes
Proper utilizations (and display, with better localization) in the explorer will be developed further in subsequent PRs.