Skip to content

chore: Remove unused identifiers in globalApi.svelte.ts - #1267

Open
enzi221 wants to merge 2 commits into
kwaroran:mainfrom
enzi221:chore/import-cleanup
Open

enzi221 wants to merge 2 commits into
kwaroran:mainfrom
enzi221:chore/import-cleanup

Conversation

@enzi221

@enzi221 enzi221 commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?

Summary

Removes all unused imports. Also removes appWindow, formDataToString(), trimNonLatin().

Related Issues

None.

Changes

Please refer to the Summary. Exception: AI law related codes were kept as-is.

Impact

None; everything were never referenced.

@enzi221
enzi221 force-pushed the chore/import-cleanup branch 2 times, most recently from 662e522 to 14951a4 Compare February 21, 2026 06:48
@enzi221
enzi221 force-pushed the chore/import-cleanup branch 2 times, most recently from 1cc2a43 to 37abfa1 Compare March 2, 2026 12:53
@enzi221
enzi221 force-pushed the chore/import-cleanup branch from 37abfa1 to 42f0238 Compare March 7, 2026 15:09

@cubicj cubicj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. I don't see current references to formDataToString() or trimNonLatin(), so the direction looks reasonable.

This now conflicts with main in src/ts/globalApi.svelte.ts, and the conflict is around imports that current main actively uses.

Could you rebase this on the current main and reapply the cleanup there?

@enzi221
enzi221 force-pushed the chore/import-cleanup branch from 42f0238 to ce5ca32 Compare August 30, 2026 16:06
@enzi221
enzi221 force-pushed the chore/import-cleanup branch from ce5ca32 to b1bc4ca Compare September 19, 2026 07:00
@enzi221
enzi221 force-pushed the chore/import-cleanup branch from b1bc4ca to dbed27e Compare September 30, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants