Skip to content

M134 public #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 5, 2025
Merged

M134 public #308

merged 36 commits into from
Feb 5, 2025

Conversation

HinTak
Copy link
Collaborator

@HinTak HinTak commented Feb 4, 2025

There is no interesting change from upgrading skia to m134; but I'll pull a few of the other pulls which are mature enough to go in for the next release.

This is inclusive of #302 (and #296) at this point , just to build successfully.

HinTak and others added 30 commits November 27, 2024 19:43
See
python/cpython#128161
"Defining iterator in a separate class no longer works in 3.13"

We have iterator for SkTextBlob defined by SkTextBlob::Iter(textblob),
which is the c++/pybind11 equivalent of the same situation.
Following the suggestion:
python/cpython#128161 (comment)

Also see actions/runner-images#11241

Fixes kyamagu#295
…88ac03 to canvaskit/0.38.2-6918-gc17fe9bc15)
Fixes minor conllisions, added some blank lines and fixes missing end-of-line at the last line, too.

Conflicts:
	src/skia/Paragraph.cpp
	tests/test_paragraph.py
@HinTak
Copy link
Collaborator Author

HinTak commented Feb 4, 2025

Pull in #299 , #293, #292, and #285.

@HinTak
Copy link
Collaborator Author

HinTak commented Feb 4, 2025

@kyamagu ready to go, I think. As usual, please read README.m134 first.

@HinTak HinTak requested a review from kyamagu February 4, 2025 22:58
@kyamagu
Copy link
Owner

kyamagu commented Feb 5, 2025

@HinTak Thanks for all the efforts!

Looking at the paragraph tests, I feel there should be a tutorial document that covers the general usage of this module. This is optional and can be in the next update.

@HinTak
Copy link
Collaborator Author

HinTak commented Feb 5, 2025

@kyamagu the most interesting use at the moment is this python port of a rust-skia example :
https://github.com/HinTak/skia-python-examples/blob/4b25ec81bd92aa59e542e44008c95e39dc70b08b/skparagraph-example.py#L7
I think I can expand and add something about the recent additions. These go under the doc/tutorials and notebook directories?

@kyamagu
Copy link
Owner

kyamagu commented Feb 5, 2025

@HinTak, yes, a user tutorial should be under doc/tutorials, or you can simply add a new directory containing examples instead of notebooks, assuming that code examples are easy to follow.

@HinTak HinTak merged commit de658a4 into kyamagu:main Feb 5, 2025
18 checks passed
@HinTak HinTak deleted the m134-public branch February 5, 2025 17:47
@HinTak
Copy link
Collaborator Author

HinTak commented Feb 6, 2025

For the record,
2166 passed, 104 skipped, 18 xfailed, 27 warnings - ubuntu
1946 passed, 331 skipped, 11 xfailed, 26 warnings - windows
2161 passed, 110 skipped, 18 xfailed, 27 warnings - mac os x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants