-
Notifications
You must be signed in to change notification settings - Fork 45
M134 public #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M134 public #308
Conversation
See python/cpython#128161 "Defining iterator in a separate class no longer works in 3.13" We have iterator for SkTextBlob defined by SkTextBlob::Iter(textblob), which is the c++/pybind11 equivalent of the same situation. Following the suggestion: python/cpython#128161 (comment) Also see actions/runner-images#11241 Fixes kyamagu#295
…_New_Custom_Directory
…ht on textlayout.Paragraph
…88ac03 to canvaskit/0.38.2-6918-gc17fe9bc15)
….2-7362-gcddf7da9da)
…skit/0.38.2-7367-gecebe83188)
…nvaskit/0.38.2-7367-gecebe83188)
…ns.subset.ttf, DejaVuSans.subset_noHx.ttf}
Fixes minor conllisions, added some blank lines and fixes missing end-of-line at the last line, too. Conflicts: src/skia/Paragraph.cpp tests/test_paragraph.py
@kyamagu ready to go, I think. As usual, please read README.m134 first. |
@HinTak Thanks for all the efforts! Looking at the paragraph tests, I feel there should be a tutorial document that covers the general usage of this module. This is optional and can be in the next update. |
@kyamagu the most interesting use at the moment is this python port of a rust-skia example : |
@HinTak, yes, a user tutorial should be under |
For the record, |
There is no interesting change from upgrading skia to m134; but I'll pull a few of the other pulls which are mature enough to go in for the next release.
This is inclusive of #302 (and #296) at this point , just to build successfully.