Skip to content

Fix interface details not updating #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viniarck merged 1 commit into from
Apr 22, 2022
Merged

Fix interface details not updating #89

viniarck merged 1 commit into from
Apr 22, 2022

Conversation

@Alopalao
Copy link

@Alopalao Alopalao commented Apr 11, 2022

This PR is needed for UI PR #26 based on issue #14
The content.interfaces from k-info-panel/switch_info was not updating. So, now interfaces array is updated from an api call. Probably a temporal solution.

@Alopalao Alopalao mentioned this pull request Apr 11, 2022
Merged
@viniarck viniarck requested review from rmotitsuki and viniarck April 15, 2022 13:37
viniarck
viniarck approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks goods to me @Alopalao.

This API call was already in place, binding the interfaces values makes sense to me.

viniarck
viniarck approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @Alopalao

@viniarck viniarck merged commit 77af290 into kytos-ng:master Apr 22, 2022
@Alopalao Alopalao deleted the fix/UI_issue_14 branch September 27, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viniarck viniarck viniarck approved these changes

@rmotitsuki rmotitsuki Awaiting requested review from rmotitsuki

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alopalao @viniarck