fix(FR-890): Fix pagination count issue in agent summary table #3567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.93% | 409/10408 |
| 🔴 | Branches | 3.3% | 240/7277 |
| 🔴 | Functions | 2.39% | 79/3299 |
| 🔴 | Lines | 3.87% | 394/10185 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 251d35d
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the pagination total count in the AgentSummaryList component so that it reflects the number of filtered agent summaries rather than the entire list.
- Replaces the use of agent_summary_list.total_count with filteredAgentSummaryList.length for the pagination total.
- Updates the pagination configuration in AgentSummaryList to accurately display the count after filtering.
Merge activity
|
Resolves #3566 ([FR-890](https://lablup.atlassian.net/browse/FR-890)) # Fix pagination total count in AgentSummaryList This PR updates the pagination total count in the AgentSummaryList component to use the length of the filtered agent summary list instead of the total count from the agent summary list. This ensures that the pagination accurately reflects the number of items currently being displayed after filtering. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup): dogbowl - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-890]: https://lablup.atlassian.net/browse/FR-890?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
fix_FR-890_/fix-pagination-count-in-agent-summary-table
branch
from
b2c9448 to
251d35d
Compare
graphite-app
bot
deleted the
fix_FR-890_/fix-pagination-count-in-agent-summary-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3566 (FR-890)
Fix pagination total count in AgentSummaryList
This PR updates the pagination total count in the AgentSummaryList component to use the length of the filtered agent summary list instead of the total count from the agent summary list. This ensures that the pagination accurately reflects the number of items currently being displayed after filtering.
Checklist: