fix(FR-1019): show proper error msg when inviting vfolder again to user already accept invitation #3693
Conversation
github-actions
bot
added
area:ux
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.93% | 409/10411 |
| 🔴 | Branches | 3.3% | 240/7279 |
| 🔴 | Functions | 2.39% | 79/3299 |
| 🔴 | Lines | 3.87% | 394/10188 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 3683a2e
nowgnuesLee
requested review from
Copilot,
agatha197,
ironAiken2,
lizable and
yomybaby
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for the 409 error code when inviting users in the InviteFolderSettingModal. The changes include adding a new translation key "UserIsAlreadyInvited" in several i18n files and updating the error handling logic in the InviteFolderSettingModal component to display an appropriate message.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| resources/i18n/*.json (vi, tr, th, ru, pt, etc.) | Added missing comma and new translation key "UserIsAlreadyInvited" for 409 error. |
| react/src/components/InviteFolderSettingModal.tsx | Updated onError handler to check for 409 status code and display error message. |
nowgnuesLee
force-pushed
the
fix/err-409-invite-folder
branch
2 times, most recently
from
1f55590 to
c8e2ab8
Compare
There was a problem hiding this comment.
@nowgnuesLee
Couldn't be better to change the PR title to this?
"Show error msg when inviting vfolder again to user already accept invitation". For now the title is too vague.
nowgnuesLee
changed the title
nowgnuesLee
changed the title
Merge activity
|
…er already accept invitation (#3693) resolves #3692 (FR-1019) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> Add error handling for the 409 error code to `InviteFolderSettingModal` in that PR. **changes** * I changed it from `emails` to `email` because you can't put multiple email values at once. **how to test** You'll see this wording when you invite a user who has already been invited one more time. ![CleanShot 2025-05-21 at [email protected]](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/xbCemO1RqqcSjEXCRK3p/25288968-5ee5-4562-a1c9-7682222dc44e.png) **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
fix/err-409-invite-folder
branch
from
c8e2ab8 to
3683a2e
Compare
resolves #3692 (FR-1019)
Add error handling for the 409 error code to
InviteFolderSettingModalin that PR.changes
emailstoemailbecause you can't put multiple email values at once.how to test
You'll see this wording when you invite a user who has already been invited one more time.
Checklist: (if applicable)