Skip to content

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Jul 14, 2025

resolves #3923 (FR-1223)

updated the package.json file to publish the package to npm.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Jul 14, 2025
@nowgnuesLee
Copy link
Contributor Author

nowgnuesLee commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee force-pushed the feat/bui-deploy-npm branch from b0b835f to 1aa155c Compare July 15, 2025 05:25
@github-actions github-actions bot added size:L 100~500 LoC and removed size:S 10~30 LoC labels Jul 15, 2025
@github-actions
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.58% (+0.01% 🔼)
493/10763
🔴 Branches
4.02% (+0.01% 🔼)
306/7620
🔴 Functions
2.66% (+0% 🔼)
91/3419
🔴 Lines
4.54% (+0.01% 🔼)
478/10527
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 helper/index.tsx
44.25% (-1.37% 🔻)
43.98% (-1.92% 🔻)
30% (-0.51% 🔻)
45.05% (-1.34% 🔻)

Test suite run success

159 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 1aa155c

@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Oct 28, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review October 28, 2025 02:52
@nowgnuesLee nowgnuesLee requested review from agatha197, Copilot, ironAiken2 and yomybaby and removed request for Copilot October 28, 2025 02:52
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Coverage report for ./packages/backend.ai-ui

St.
Category Percentage Covered / Total
🔴 Statements 51.38% 130/253
🔴 Branches 30.3% 80/264
🔴 Functions 34.48% 20/58
🔴 Lines 53.85% 119/221

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 38bf4ce

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a library package, frameworks or libraries like React and Ant Design (antd) should typically be listed under peerDependencies rather than dependencies. This is because peerDependencies allow the consuming project to manage the specific versions of these dependencies, ensuring compatibility and avoiding multiple instances of the same dependency.

If these packages are also listed in dependencies, it can lead to duplication or conflicts, as the library will install its own versions of these dependencies, potentially causing issues like multiple React instances or mismatched versions.

ref: https://www.geeksforgeeks.org/node-js/difference-between-dependencies-devdependencies-and-peerdependencies/, https://angular.love/npm-peer-dependencies/


How about considering the prepublishOnly option? It automatically executes essential tasks such as build, test, and lint right before publishing, helping to prevent the accidental deployment of code with errors.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the Makefile so that the version is changed when running the make versiontag command?

https://github.com/lablup/backend.ai-webui/blob/67f58f71335f42c05c00f889dcceff2177391f46/Makefile#L37

Copilot AI review requested due to automatic review settings October 31, 2025 07:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades Relay and various Babel dependencies in a monorepo. The main changes focus on updating the relay-compiler, babel-plugin-relay, and associated Babel ecosystem packages to newer versions.

Key changes:

  • Upgrades relay-compiler and babel-plugin-relay from 20.1.0 to 20.1.1
  • Updates @babel/runtime from 7.27.0 to 7.28.4 across the codebase
  • Prepares the backend.ai-ui package for publication by adding package metadata and a prepublishOnly script

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-lock.yaml Updates Relay packages to 20.1.1 and Babel dependencies to latest versions, removes unused package resolutions
packages/backend.ai-ui/package.json Adds package metadata for npm publication and moves @ant-design/icons and @tanstack/react-query to peerDependencies
Makefile Extends version tagging to include the backend.ai-ui package
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nowgnuesLee nowgnuesLee force-pushed the feat/bui-deploy-npm branch 7 times, most recently from fdc8f2c to ec9d8ef Compare November 3, 2025 05:45
@nowgnuesLee nowgnuesLee force-pushed the feat/bui-deploy-npm branch 6 times, most recently from e6ee658 to ae9e506 Compare November 4, 2025 05:01
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to keep the repo version as "25.16.0-alpha.0" and have canary builds follow the pattern 25.16.0-canary-*** instead of 25.16.0-alpha.0-canary-***.
Please review this suggestion.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Nov 5, 2025

Merge activity

resolves #3923 (FR-1223)

updated the package.json file to publish the package to npm.

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feat/bui-deploy-npm branch from 65aa578 to 38bf4ce Compare November 5, 2025 01:43
@graphite-app graphite-app bot merged commit 38bf4ce into main Nov 5, 2025
11 checks passed
@graphite-app graphite-app bot deleted the feat/bui-deploy-npm branch November 5, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy to npm as backend.ai-ui

4 participants