-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1223): deploy to npm as backend.ai-ui #3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
b0b835f to
1aa155c
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.58% (+0.01% 🔼) |
493/10763 |
| 🔴 | Branches | 4.02% (+0.01% 🔼) |
306/7620 |
| 🔴 | Functions | 2.66% (+0% 🔼) |
91/3419 |
| 🔴 | Lines | 4.54% (+0.01% 🔼) |
478/10527 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | helper/index.tsx | 44.25% (-1.37% 🔻) |
43.98% (-1.92% 🔻) |
30% (-0.51% 🔻) |
45.05% (-1.34% 🔻) |
Test suite run success
159 tests passing in 15 suites.
Report generated by 🧪jest coverage report action from 1aa155c
1aa155c to
1d49adb
Compare
1d49adb to
3319c8f
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 51.38% | 130/253 |
| 🔴 | Branches | 30.3% | 80/264 |
| 🔴 | Functions | 34.48% | 20/58 |
| 🔴 | Lines | 53.85% | 119/221 |
Test suite run success
55 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from 38bf4ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a library package, frameworks or libraries like React and Ant Design (antd) should typically be listed under peerDependencies rather than dependencies. This is because peerDependencies allow the consuming project to manage the specific versions of these dependencies, ensuring compatibility and avoiding multiple instances of the same dependency.
If these packages are also listed in dependencies, it can lead to duplication or conflicts, as the library will install its own versions of these dependencies, potentially causing issues like multiple React instances or mismatched versions.
ref: https://www.geeksforgeeks.org/node-js/difference-between-dependencies-devdependencies-and-peerdependencies/, https://angular.love/npm-peer-dependencies/
How about considering the prepublishOnly option? It automatically executes essential tasks such as build, test, and lint right before publishing, helping to prevent the accidental deployment of code with errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the Makefile so that the version is changed when running the make versiontag command?
3319c8f to
28d2f14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request upgrades Relay and various Babel dependencies in a monorepo. The main changes focus on updating the relay-compiler, babel-plugin-relay, and associated Babel ecosystem packages to newer versions.
Key changes:
- Upgrades
relay-compilerandbabel-plugin-relayfrom 20.1.0 to 20.1.1 - Updates
@babel/runtimefrom 7.27.0 to 7.28.4 across the codebase - Prepares the
backend.ai-uipackage for publication by adding package metadata and aprepublishOnlyscript
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates Relay packages to 20.1.1 and Babel dependencies to latest versions, removes unused package resolutions |
| packages/backend.ai-ui/package.json | Adds package metadata for npm publication and moves @ant-design/icons and @tanstack/react-query to peerDependencies |
| Makefile | Extends version tagging to include the backend.ai-ui package |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fdc8f2c to
ec9d8ef
Compare
e6ee658 to
ae9e506
Compare
ae9e506 to
51b3629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to keep the repo version as "25.16.0-alpha.0" and have canary builds follow the pattern 25.16.0-canary-*** instead of 25.16.0-alpha.0-canary-***.
Please review this suggestion.
51b3629 to
65aa578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
resolves #3923 (FR-1223) updated the package.json file to publish the package to npm. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
65aa578 to
38bf4ce
Compare

resolves #3923 (FR-1223)
updated the package.json file to publish the package to npm.
Checklist: (if applicable)