Skip to content

Conversation

@fregataa
Copy link
Member

@fregataa fregataa commented May 17, 2024

Agent registers kernel ids to its terminating_kernels so that it can track kernels under "terminate" lifecycle.
There are some holes that kernel ids cannot be deleted from the terminating_kernels, which block destroying or cleaning the kernels by sync_container_lifecycle task.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added the urgency:4 As soon as feasible, implementation is essential. label May 17, 2024
@fregataa fregataa added this to the 24.03 milestone May 17, 2024
@fregataa fregataa self-assigned this May 17, 2024
@graphite-app
Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:agent Related to Agent component size:XS ~10 LoC labels May 17, 2024
@fregataa fregataa requested a review from achimnol May 17, 2024 13:14
@fregataa fregataa added urgency:5 It is imperative that action be taken right away. and removed urgency:4 As soon as feasible, implementation is essential. labels May 21, 2024
@fregataa fregataa marked this pull request as draft May 23, 2024 05:24
@fregataa fregataa removed the request for review from achimnol May 23, 2024 05:24
@fregataa fregataa removed the urgency:5 It is imperative that action be taken right away. label May 24, 2024
@fregataa
Copy link
Member Author

Continue this work on #2178 , close this PR

@fregataa fregataa closed this May 26, 2024
@Yaminyam Yaminyam deleted the fix/ghost-terminating-kernels branch July 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:agent Related to Agent component size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants