Skip to content

feat(BA-2134, BA-2128): Modifying GQL Schema Details for Model Deployment Implementation #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 17, 2025
Merged

feat(BA-2134, BA-2128): Modifying GQL Schema Details for Model Deployment Implementation #5548

merged 13 commits into from
Oct 17, 2025

Conversation

@seedspirit
Copy link
Contributor

@seedspirit seedspirit commented Aug 17, 2025 •
edited by github-actions bot
Loading

resolves #5520, #5513 (BA-2134, BA-2128)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--5548.org.readthedocs.build/en/5548/

📚 Documentation preview 📚: https://sorna-ko--5548.org.readthedocs.build/ko/5548/

@seedspirit seedspirit self-assigned this Aug 17, 2025
@github-actions github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component area:docs Documentations labels Aug 17, 2025
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Aug 18, 2025
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 7 times, most recently from be3353f to 8cfd3c2 Compare August 20, 2025 06:47
@seedspirit seedspirit changed the title feat(BA-2134): Modifying GQL Schema Details for Model Deployment Implementation (WIP) feat(BA-2134, BA-2128): Modifying GQL Schema Details for Model Deployment Implementation (WIP) Aug 20, 2025
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 4 times, most recently from 8b25d2b to fe00fc3 Compare August 21, 2025 10:49
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 3 times, most recently from ecd8cae to 3c34bb5 Compare August 22, 2025 09:41
Base automatically changed from feat/BA-2067 to main August 22, 2025 12:17
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 3 times, most recently from 18ddbc1 to 5691e39 Compare August 24, 2025 08:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 24, 2025
View reviewed changes
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 2 times, most recently from d07ebc2 to fb0d5bd Compare September 9, 2025 09:34
HyeockJinKim
HyeockJinKim reviewed Sep 22, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Sep 22, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Sep 22, 2025
View reviewed changes
src/ai/backend/manager/api/admin.py
Comment on lines -298 to -218
app_ctx.gql_schema = graphene.Schema(
query=Query,
mutation=Mutation,
auto_camelcase=False,
Copy link
Collaborator

@HyeockJinKim HyeockJinKim Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if graphene.Schema can be created only once and then reused, so please confirm it for me.

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 0f03948 Oct 17, 2025
31 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/BA-2134 branch October 17, 2025 06:57
@seedspirit seedspirit mentioned this pull request Oct 24, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@seedspirit seedspirit

Labels

area:docs Documentations comp:cli Related to CLI component comp:common Related to Common component comp:manager Related to Manager component size:XL 500~ LoC skip:changelog Make the action workflow to skip towncrier check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Model Deployment GQL schema for accurate implementation

3 participants

@seedspirit @HyeockJinKim