Skip to content

feat(BA-2213): Implement API Layer of Model Deployment #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2025
Merged

feat(BA-2213): Implement API Layer of Model Deployment #5672

merged 8 commits into from
Oct 17, 2025
+3,696 −1,096

Conversation

@seedspirit
Copy link
Contributor

@seedspirit seedspirit commented Aug 28, 2025 •
edited by github-actions bot
Loading

resolves #5668 (BA-2213)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--5672.org.readthedocs.build/en/5672/

📚 Documentation preview 📚: https://sorna-ko--5672.org.readthedocs.build/ko/5672/

@seedspirit seedspirit changed the base branch from main to feat/BA-2134 August 28, 2025 13:35
@github-actions github-actions bot added size:XL 500~ LoC comp:manager Related to Manager component labels Aug 28, 2025
@github-actions github-actions bot added area:docs Documentations comp:common Related to Common component labels Aug 31, 2025
@seedspirit seedspirit force-pushed the feat/BA-2134 branch 2 times, most recently from 893be42 to 408a3d1 Compare September 2, 2025 01:02
@seedspirit seedspirit force-pushed the feat/BA-2213 branch 2 times, most recently from 7ad8932 to 4734d21 Compare September 3, 2025 07:13
@seedspirit seedspirit marked this pull request as ready for review September 5, 2025 07:29
@seedspirit seedspirit force-pushed the feat/BA-2213 branch 2 times, most recently from 65529f1 to 3355c83 Compare September 9, 2025 09:24
HyeockJinKim
HyeockJinKim reviewed Sep 22, 2025
View reviewed changes
src/ai/backend/manager/api/gql/model_deployment/model_replica.py Outdated
Comment on lines 167 to 171
for deployment_id in deployment_ids:
action_result = await processor.get_replicas_by_deployment_id.wait_for_complete(
GetReplicasByDeploymentIdAction(deployment_id=deployment_id)
)
replicas.extend(action_result.data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is very wrong... Please revise it later. It seems to be implemented in a way that completely misses the purpose of the dataloader.

@HyeockJinKim HyeockJinKim merged commit eb8094e into feat/BA-2134 Oct 17, 2025
4 of 7 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/BA-2213 branch October 17, 2025 05:24
@seedspirit seedspirit mentioned this pull request Oct 24, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@seedspirit seedspirit

Labels

area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component size:XL 500~ LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement API Layer of Model Deployment

2 participants

@seedspirit @HyeockJinKim