Skip to content

Conversation

seedspirit
Copy link
Contributor

@seedspirit seedspirit commented Sep 5, 2025

resolves #5751 (BA-2265)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--5754.org.readthedocs.build/en/5754/


📚 Documentation preview 📚: https://sorna-ko--5754.org.readthedocs.build/ko/5754/

@seedspirit seedspirit self-assigned this Sep 5, 2025
@github-actions github-actions bot added size:XL 500~ LoC area:docs Documentations comp:manager Related to Manager component labels Sep 5, 2025
@seedspirit seedspirit added the skip:changelog Make the action workflow to skip towncrier check label Sep 8, 2025
@seedspirit seedspirit force-pushed the feat/BA-2265 branch 5 times, most recently from 973e43d to 792fc14 Compare September 9, 2025 03:36
@seedspirit seedspirit force-pushed the feat/BA-2213 branch 2 times, most recently from 3355c83 to f441367 Compare September 9, 2025 09:36
@github-actions github-actions bot added the comp:common Related to Common component label Sep 22, 2025
@seedspirit seedspirit force-pushed the feat/BA-2265 branch 3 times, most recently from dfd0ab3 to 73477b3 Compare September 24, 2025 00:01
Comment on lines +13 to +25
def __init__(self) -> None:
self._loader = {}

def get_loader(
self,
func: Callable[["StrawberryGQLContext", Any], Awaitable[Any]],
context: "StrawberryGQLContext",
) -> DataLoader:
loader = self._loader.get(func, None)
if loader is None:
new_loader = DataLoader(apartial(func, context))
self._loader[func] = new_loader
return new_loader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method doesn't look so good.

@HyeockJinKim HyeockJinKim merged commit e27dc38 into feat/BA-2213 Oct 17, 2025
21 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/BA-2265 branch October 17, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component size:XL 500~ LoC skip:changelog Make the action workflow to skip towncrier check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants