-
Notifications
You must be signed in to change notification settings - Fork 164
feat(BA-2265): Add filtering and pagination support to Model Deployment API endpoints #5754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ccc371
to
be8c442
Compare
973e43d
to
792fc14
Compare
845c15a
to
cbf8189
Compare
a560788
to
ff7525a
Compare
cbf8189
to
65529f1
Compare
39e7f5a
to
3b3da3c
Compare
3355c83
to
f441367
Compare
3b3da3c
to
f572e86
Compare
f441367
to
2b6e5fa
Compare
1ed9d1b
to
9a97542
Compare
dfd0ab3
to
73477b3
Compare
7fd1323
to
68018d8
Compare
ac753b9
to
22636a0
Compare
Comment on lines
+13
to
+25
def __init__(self) -> None: | ||
self._loader = {} | ||
|
||
def get_loader( | ||
self, | ||
func: Callable[["StrawberryGQLContext", Any], Awaitable[Any]], | ||
context: "StrawberryGQLContext", | ||
) -> DataLoader: | ||
loader = self._loader.get(func, None) | ||
if loader is None: | ||
new_loader = DataLoader(apartial(func, context)) | ||
self._loader[func] = new_loader | ||
return new_loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method doesn't look so good.
6037fd9
to
d6cf840
Compare
a47cc0e
to
aa9c97d
Compare
Co-authored-by: octodog <[email protected]>
HyeockJinKim
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:common
Related to Common component
comp:manager
Related to Manager component
size:XL
500~ LoC
skip:changelog
Make the action workflow to skip towncrier check
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5751 (BA-2265)
Checklist: (if applicable)
ai.backend.test
docs
directory📚 Documentation preview 📚: https://sorna--5754.org.readthedocs.build/en/5754/
📚 Documentation preview 📚: https://sorna-ko--5754.org.readthedocs.build/ko/5754/