fix(BA-2404): Generalize gpu_allocated field with improved SlotName and ResourceSlot typing #6087
+1,970
−840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5926 (BA-2404)
Core changes:
SlotName
to be aUserString
subclass which lazily parses the slot name format.{device_name}.{major_type}[:{minor_type}]
gpu_allocated
calculation to useSlotName.is_accelerator()
method to sum all allocated acceleratorsResourceSlot
to useUserDict
with proper generic type argumentsWarning
When there are multiple different accelerators allocated in a single container or installed in a single agent node, this simple "sum" for
gpu_allocated
may have a non-sense value when mixing different units and fraction scales. We need some design discussion here.Checklist: (if applicable)