-
Notifications
You must be signed in to change notification settings - Fork 164
feat(BA-2507): Implement periodic polling and synchronization for remote reservoir #6222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107d2a0
to
5f5fc88
Compare
3674297
to
74404a7
Compare
74404a7
to
0d4338d
Compare
Comment on lines
+79
to
+84
if event.success is False: | ||
log.warning("Model import failed: {} revision: {}", event.model_id, event.revision) | ||
await self._artifact_repository.update_artifact_revision_status( | ||
revision.id, ArtifactStatus.FAILED | ||
) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not event.success:
HyeockJinKim
approved these changes
Oct 13, 2025
It should be handled in the DB source, rather than directly implementing the DB operation in the repository. |
jopemachine
added a commit
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:common
Related to Common component
comp:manager
Related to Manager component
comp:storage-proxy
Related to Storage proxy component
size:XL
500~ LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6030 (BA-2507)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--6222.org.readthedocs.build/en/6222/
📚 Documentation preview 📚: https://sorna-ko--6222.org.readthedocs.build/ko/6222/