Skip to content

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Oct 7, 2025

resolves #6030 (BA-2507)

Checklist: (if applicable)

  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--6222.org.readthedocs.build/en/6222/


📚 Documentation preview 📚: https://sorna-ko--6222.org.readthedocs.build/ko/6222/

@jopemachine jopemachine changed the title feat(BA-2507): Implement periodic polling and synchronization for remote reservoir feat(BA-2507): Implement periodic polling and synchronization for remote reservoir (WIP) Oct 7, 2025
@github-actions github-actions bot added size:M 30~100 LoC comp:manager Related to Manager component labels Oct 7, 2025
@jopemachine jopemachine added this to the 25.15 milestone Oct 7, 2025
@github-actions github-actions bot added size:L 100~500 LoC area:docs Documentations comp:common Related to Common component and removed size:M 30~100 LoC labels Oct 7, 2025
@jopemachine jopemachine modified the milestones: 25.15, 25.16 Oct 12, 2025
@jopemachine jopemachine marked this pull request as ready for review October 12, 2025 05:51
@jopemachine jopemachine changed the title feat(BA-2507): Implement periodic polling and synchronization for remote reservoir (WIP) feat(BA-2507): Implement periodic polling and synchronization for remote reservoir Oct 12, 2025
@jopemachine jopemachine force-pushed the feat/BA-2507 branch 2 times, most recently from 3674297 to 74404a7 Compare October 12, 2025 11:40
@github-actions github-actions bot added size:XL 500~ LoC comp:storage-proxy Related to Storage proxy component and removed size:L 100~500 LoC labels Oct 13, 2025
Comment on lines +79 to +84
if event.success is False:
log.warning("Model import failed: {} revision: {}", event.model_id, event.revision)
await self._artifact_repository.update_artifact_revision_status(
revision.id, ArtifactStatus.FAILED
)
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not event.success:

@HyeockJinKim
Copy link
Collaborator

It should be handled in the DB source, rather than directly implementing the DB operation in the repository.

@HyeockJinKim HyeockJinKim merged commit 1cafe35 into feat/BA-2508 Oct 13, 2025
21 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/BA-2507 branch October 13, 2025 08:41
jopemachine added a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants