Skip to content

refactor(BA-3046): Return a dataclass instead of a dict when fetching Known Registries #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: refactor/BA-2970
Choose a base branch
from
Open

refactor(BA-3046): Return a dataclass instead of a dict when fetching Known Registries #6808

wants to merge 5 commits into from

Conversation

@seedspirit
Copy link
Contributor

@seedspirit seedspirit commented Nov 18, 2025 •
edited by github-actions bot
Loading

resolves #6758 (BA-3046)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--6808.org.readthedocs.build/en/6808/

📚 Documentation preview 📚: https://sorna-ko--6808.org.readthedocs.build/ko/6808/

@github-actions github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component labels Nov 18, 2025
@seedspirit seedspirit changed the title refactor: Introduce DB Source in container registry repository refactor(BA-3046): Changed to use a dataclass instead of a dict when returning the Known Registry Nov 18, 2025
@github-actions github-actions bot added the area:docs Documentations label Nov 18, 2025
@seedspirit seedspirit changed the title refactor(BA-3046): Changed to use a dataclass instead of a dict when returning the Known Registry refactor(BA-3046): Return a dataclass instead of a dict when fetching Known Registries Nov 18, 2025
@seedspirit seedspirit marked this pull request as ready for review November 18, 2025 06:24
@seedspirit seedspirit mentioned this pull request Nov 18, 2025
Open
7 tasks
HyeockJinKim
HyeockJinKim reviewed Nov 18, 2025
View reviewed changes
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Nov 19, 2025
@seedspirit seedspirit requested a review from fregataa November 24, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim left review comments

@fregataa fregataa Awaiting requested review from fregataa

Assignees

@seedspirit seedspirit

Labels

area:docs Documentations comp:manager Related to Manager component size:XL 500~ LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seedspirit @HyeockJinKim