Improve BasicAuth middleware: use strings.Cut and RFC compliance #2825
+74
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace manual for loop with strings.Cut for credential parsing - Simplify realm handling to always quote according to RFC 7617 - Improve code readability and maintainability Fixes #2794 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
aldas
requested changes
Sep 16, 2025
middleware/basic_auth.go
Outdated
| // Need to return `401` for browsers to pop-up login box. | ||
| c.Response().Header().Set(echo.HeaderWWWAuthenticate, basic+" realm="+realm) | ||
| // Realm is case-insensitive, so we can use "basic" directly. See RFC 7617. | ||
| c.Response().Header().Set(echo.HeaderWWWAuthenticate, basic+" realm="+strconv.Quote(config.Realm)) |
There was a problem hiding this comment.
strconv.Quote could be moved to line 68 so it would be done once when middleware is created.
Tests cover: - Default realm quoting - Custom realm with spaces - Special characters (quotes, backslashes) - Empty realm fallback to default - Unicode realm support Addresses review feedback about testing strconv.Quote behavior in WWW-Authenticate header per RFC 7617 compliance. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Move strconv.Quote(config.Realm) from per-request execution to middleware initialization for better performance. - Pre-compute quoted realm at middleware creation time - Avoids repeated string operations on every auth failure - Maintains same behavior with better efficiency Performance improvement suggested during code review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the BasicAuth middleware with improved code readability and RFC compliance.
Changes:
strings.Cutfor credential parsing - Replaces manual for loop with Go 1.18+strings.CutBenefits:
Test plan
Fixes #2794
🤖 Generated with Claude Code