-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to delay going to pending state on refetch #8
Open
LFDM
wants to merge
15
commits into
master
Choose a base branch
from
delay-pending
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever incoming props change and the component needs to refetch, we would go to pending state. If all data that needed resolution was available immediately (immediately means: promises which resolve immediately), this lead to the following situation:
We can now opt-into a waiting time to defer going to the pending state altogether.
At the point of a refetch we do have data to display already - so instead of going to pending, we just opt-in to show the old data a little longer, before displaying a pending component (or the next view state, in case the data arrives inside of the specified delay window).
This is opt-in for now - there might be cases where mounting and unmounting are exactly what you want, so there will always be a way out of this (e.g. for some sort of animation), but a feature version might default to do skip this pending state for a tiny bit.
An interesting change in this aspect is this 5c26407. Without this commit the view component would still have rerendered immediately with the new props incoming. It would have received new components passed down from the outside, but still gotten the old data.
This commit prevents this - as long as the delay is in effect, the view component will not know anything about a prop change.
IMO it needs to be this way - because up until now the inner component was guaranteed to receive all incoming props as well as the resolved data
withData
provides. We should not break this contract, as a mismatch of incoming and resolved props could potentially lead to bugs.The feature is fully working
Ideally this could be solved without timeouts, but i think it just can't. Currently setting the timeout length to
0
will also skip the delay - this is something which could change imo.Will open a second PR in a bit, which builds up on this and deals with a
minimumPendingTime
- which is not 100% there yet.