Skip to content

style(writer): Ignore illegal characters when encoding for DesignBuilder #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Jan 28, 2026
Merged

style(writer): Ignore illegal characters when encoding for DesignBuilder #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dragonfly_designbuilder/cli/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def model_to_dsbxml(
dsbxml_str = writer_model_to_dsbxml(
model, multiplier, no_plenum, ceil_adjacency, merge_method,
xml_template=xml_template, program_name=program_name)
f_contents = dsbxml_str.encode('iso-8859-15')
f_contents = dsbxml_str.encode('iso-8859-15', errors='ignore')
if output_file is None:
b = base64.b64encode(f_contents)
base64_string = b.decode('utf-8')
Expand Down
2 changes: 1 addition & 1 deletion dragonfly_designbuilder/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,5 +203,5 @@ def model_to_dsbxml_file(
)
# write the string into the file and encode it in ISO-8859-15
with open(output_file, 'wb') as fp:
fp.write(xml_str.encode('iso-8859-15'))
fp.write(xml_str.encode('iso-8859-15', errors='ignore'))
return output_file