Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

bug fix: partials do not render on windows 7. #119

Open
s-oram wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix: partials do not render on windows 7. #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/template_handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = {
return false;
}

var path_portions = template_path.split(Path.sep || "/");
var path_portions = template_path.split("/");
Copy link
Owner

@laktek laktek Jan 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm..weird. What's returned in windows for Path.sep?

Copy link
Author

@s-oram s-oram Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path.sep returns \

Copy link
Author

@s-oram s-oram Feb 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in template_handler.js isSection: function(template_path){}
the template_path variable contains paths formatted like /images\banner.

if(_.any(path_portions, function(portion){ return portion[0] === "."; })){
return false;
}
Expand Down Expand Up @@ -232,7 +232,7 @@ module.exports = {
};

var directories_to_look = [];
_.each(basePath.split(Path.sep || "/"), function(current_dir_entry){
_.each(basePath.split("/"), function(current_dir_entry){
var previous_dir_entry;

if(directories_to_look.length) {
Expand Down