Skip to content

Use space/tab instead of word boundary for keyword#5

Open
traytonwhite wants to merge 1 commit intolalyos:masterfrom
traytonwhite:whitespacekeywordboundary
Open

Use space/tab instead of word boundary for keyword#5
traytonwhite wants to merge 1 commit intolalyos:masterfrom
traytonwhite:whitespacekeywordboundary

Conversation

@traytonwhite
Copy link
Copy Markdown

Potentially fixes #3 - not sure if users would want to replace other \\b instances with explicit whitespace for boundaries elsewhere in ssh-config.cson

@lalyos
Copy link
Copy Markdown
Owner

lalyos commented Nov 21, 2016

Sorry for slow response time.
@traytonwhite could you please describe me, how can i test your version?

@walles
Copy link
Copy Markdown
Contributor

walles commented Apr 20, 2017

Adding a unit test for #3 in here would definitely help.

#6 comes with unit tests, so if / after that one is merged it shouldn't be too hard to add another test case for this.

@lalyos
Copy link
Copy Markdown
Owner

lalyos commented Jun 19, 2017

@traytonwhite or @walles if you could provide some minimal unit tests i can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matches keywords in values

3 participants