-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests for prepare_os_context #114
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except from the questions below.
On another note, we should start thinking about adding a proper test framework for Python I believe. Probably PyTest.
python3 hints_tests.py && \ | ||
python3 get_builtins_initial_stack.py && \ | ||
./run_python_tests.sh && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PYENV_VERSION
still the same here? I'm not entirely sure if the venv
takes care of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as i know yes, venv takes care about the python version with which the tests are ran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure?
echo "Running hint tests" | ||
python3 tests/hints_tests.py | ||
python3 tests/get_builtins_initial_stack.py | ||
|
||
echo "Running prepare_os_context integration tests" | ||
python3 tests/prepare_os_context.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question.
No description provided.