Skip to content

Conversation

DiegoCivi
Copy link
Contributor

@DiegoCivi DiegoCivi commented Sep 29, 2025

Unify deps makefile target

Description

Tested this on mac and linux by doing make deps and then make tests. It worked on both.

Closes #2097

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Sep 29, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.757 s ±  0.000 s    [User: 23.883 s, System: 0.871 s]
  Range (min … max):   24.757 s … 24.757 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.737 s ±  0.001 s    [User: 23.854 s, System: 0.880 s]
  Range (min … max):   24.736 s … 24.738 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.477 s ±  0.010 s    [User: 23.988 s, System: 0.902 s]
  Range (min … max):   13.469 s … 13.484 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.484 s ±  0.007 s    [User: 24.020 s, System: 0.908 s]
  Range (min … max):   13.480 s … 13.489 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.239 s ±  0.083 s    [User: 36.223 s, System: 1.082 s]
  Range (min … max):   10.181 s … 10.298 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.132 s ±  0.041 s    [User: 36.825 s, System: 1.063 s]
  Range (min … max):   10.103 s … 10.161 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.089 s ±  0.110 s    [User: 36.801 s, System: 1.079 s]
  Range (min … max):   10.011 s … 10.167 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.216 s ±  0.051 s    [User: 36.737 s, System: 1.087 s]
  Range (min … max):   10.180 s … 10.252 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.159 s ±  0.042 s    [User: 37.094 s, System: 1.089 s]
  Range (min … max):   10.129 s … 10.188 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.997 s ±  0.058 s    [User: 37.180 s, System: 1.135 s]
  Range (min … max):    9.956 s … 10.038 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.089 s ±  0.015 s    [User: 37.153 s, System: 1.182 s]
  Range (min … max):   10.078 s … 10.099 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.018 s ±  0.071 s    [User: 37.414 s, System: 1.191 s]
  Range (min … max):    9.968 s … 10.068 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 16


Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.108 ± 0.025 2.072 2.153 1.00 ± 0.01
head big_factorial 2.100 ± 0.012 2.080 2.118 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.028 ± 0.014 2.010 2.050 1.00 ± 0.01
head big_fibonacci 2.024 ± 0.020 2.002 2.067 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.293 ± 0.072 7.150 7.419 1.00
head blake2s_integration_benchmark 7.326 ± 0.091 7.136 7.434 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.188 ± 0.031 2.145 2.237 1.01 ± 0.02
head compare_arrays_200000 2.167 ± 0.028 2.125 2.208 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.419 ± 0.011 1.406 1.447 1.00
head dict_integration_benchmark 1.431 ± 0.013 1.407 1.449 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.206 ± 0.013 1.188 1.223 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.203 ± 0.007 1.191 1.211 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.387 ± 0.136 7.213 7.709 1.00
head integration_builtins 7.391 ± 0.101 7.185 7.547 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.470 ± 0.195 7.272 7.974 1.00
head keccak_integration_benchmark 7.491 ± 0.186 7.285 7.869 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.165 ± 0.022 2.135 2.212 1.01 ± 0.02
head linear_search 2.153 ± 0.031 2.104 2.219 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.502 ± 0.024 1.469 1.562 1.00
head math_cmp_and_pow_integration_benchmark 1.508 ± 0.023 1.485 1.560 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.454 ± 0.009 1.438 1.469 1.00
head math_integration_benchmark 1.455 ± 0.018 1.433 1.481 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.215 ± 0.024 1.183 1.273 1.00 ± 0.02
head memory_integration_benchmark 1.209 ± 0.017 1.183 1.230 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.538 ± 0.013 1.526 1.567 1.00
head operations_with_data_structures_benchmarks 1.543 ± 0.018 1.524 1.576 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 529.4 ± 5.7 520.9 538.9 1.00
head pedersen 533.2 ± 3.9 527.3 541.9 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 618.5 ± 5.4 606.7 626.0 1.00
head poseidon_integration_benchmark 619.6 ± 8.6 610.0 634.0 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.773 ± 0.012 1.750 1.792 1.00
head secp_integration_benchmark 1.792 ± 0.009 1.776 1.806 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 649.2 ± 7.1 641.6 666.2 1.00
head set_integration_benchmark 663.3 ± 17.4 646.0 689.1 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.176 ± 0.078 4.094 4.351 1.00
head uint256_integration_benchmark 4.189 ± 0.068 4.115 4.302 1.00 ± 0.02

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (958ae7e) to head (9318b7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         104      104           
  Lines       44027    44027           
=======================================
  Hits        42566    42566           
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DiegoCivi DiegoCivi marked this pull request as ready for review September 30, 2025 15:37
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify deps make command so that it does not depend on OS
3 participants