Skip to content

Conversation

DiegoCivi
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Oct 1, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.746 s ±  0.030 s    [User: 23.880 s, System: 0.864 s]
  Range (min … max):   24.726 s … 24.767 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.701 s ±  0.003 s    [User: 23.844 s, System: 0.854 s]
  Range (min … max):   24.699 s … 24.704 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.492 s ±  0.045 s    [User: 24.009 s, System: 0.862 s]
  Range (min … max):   13.460 s … 13.524 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.422 s ±  0.025 s    [User: 23.898 s, System: 0.878 s]
  Range (min … max):   13.405 s … 13.439 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.01 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.894 s ±  0.065 s    [User: 36.905 s, System: 1.050 s]
  Range (min … max):    9.848 s …  9.940 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.617 s ±  0.020 s    [User: 36.074 s, System: 1.062 s]
  Range (min … max):   10.602 s … 10.631 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.07 ± 0.01 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.211 s ±  0.116 s    [User: 37.301 s, System: 1.074 s]
  Range (min … max):   10.129 s … 10.294 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.981 s ±  0.168 s    [User: 36.723 s, System: 1.055 s]
  Range (min … max):    9.863 s … 10.100 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.123 s ±  0.126 s    [User: 37.061 s, System: 1.103 s]
  Range (min … max):   10.034 s … 10.212 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.038 s ±  0.010 s    [User: 37.037 s, System: 1.070 s]
  Range (min … max):   10.031 s … 10.045 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.208 s ±  0.159 s    [User: 37.126 s, System: 1.223 s]
  Range (min … max):   10.096 s … 10.320 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.120 s ±  0.324 s    [User: 37.143 s, System: 1.183 s]
  Range (min … max):    9.891 s … 10.349 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Oct 1, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.110 ± 0.016 2.080 2.132 1.00
head big_factorial 2.133 ± 0.040 2.104 2.218 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.028 ± 0.020 2.003 2.061 1.00 ± 0.02
head big_fibonacci 2.028 ± 0.027 1.994 2.075 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.283 ± 0.180 7.082 7.759 1.01 ± 0.03
head blake2s_integration_benchmark 7.204 ± 0.099 7.076 7.330 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.168 ± 0.019 2.142 2.193 1.01 ± 0.01
head compare_arrays_200000 2.149 ± 0.021 2.109 2.192 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.447 ± 0.020 1.414 1.491 1.01 ± 0.02
head dict_integration_benchmark 1.427 ± 0.011 1.413 1.446 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.207 ± 0.014 1.187 1.223 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.198 ± 0.010 1.182 1.209 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.358 ± 0.080 7.219 7.439 1.00
head integration_builtins 7.363 ± 0.068 7.222 7.448 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.381 ± 0.152 7.230 7.685 1.00
head keccak_integration_benchmark 7.429 ± 0.041 7.368 7.489 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.171 ± 0.030 2.115 2.223 1.00 ± 0.02
head linear_search 2.163 ± 0.016 2.144 2.193 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.516 ± 0.011 1.494 1.531 1.00
head math_cmp_and_pow_integration_benchmark 1.519 ± 0.011 1.502 1.533 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.454 ± 0.012 1.437 1.478 1.00
head math_integration_benchmark 1.465 ± 0.020 1.434 1.504 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.215 ± 0.010 1.200 1.229 1.00
head memory_integration_benchmark 1.223 ± 0.011 1.203 1.243 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.538 ± 0.009 1.527 1.552 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.531 ± 0.008 1.522 1.547 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 526.1 ± 6.0 521.9 538.8 1.00
head pedersen 528.6 ± 4.2 523.9 536.1 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 619.0 ± 4.2 608.0 622.9 1.01 ± 0.01
head poseidon_integration_benchmark 615.3 ± 4.5 605.5 620.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.782 ± 0.010 1.768 1.798 1.01 ± 0.01
head secp_integration_benchmark 1.771 ± 0.008 1.758 1.783 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 651.9 ± 5.2 642.6 658.1 1.01 ± 0.01
head set_integration_benchmark 645.5 ± 3.8 641.4 653.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.165 ± 0.069 4.086 4.340 1.01 ± 0.02
head uint256_integration_benchmark 4.115 ± 0.033 4.071 4.169 1.00

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (958ae7e) to head (7e1ff49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2217   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         104      104           
  Lines       44027    44027           
=======================================
  Hits        42566    42566           
  Misses       1461     1461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DiegoCivi
Copy link
Contributor Author

I was trying to have public macros and private macros, with the public ones using the private ones. Seems that this is not possible in Rust so I reverted those commits so as to start with another approach to this issue.

@DiegoCivi
Copy link
Contributor Author

Closing this since we decided that we are not going to address this issue

@DiegoCivi DiegoCivi closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant