Fix felt252 and enum deserialization bugs. (#844)

* Fix felt252 and enum deserialization bugs. * Fix formatting. * Also fix the runtime. * Fix errors. * try to fix ci * remove unused deps --------- Co-authored-by: Edgar Luque <[email protected]>
lambdaclass · Oct 14, 2024 · 8175154 · 8175154
1 parent f862ec3
commit 8175154
Show file tree

Hide file tree

Showing 9 changed files with 150 additions and 96 deletions.
diff --git a/.github/workflows/bench-hyperfine.yml b/.github/workflows/bench-hyperfine.yml
@@ -34,7 +34,7 @@ jobs:
           sudo apt-get remove -y 'php.*'
           sudo apt-get remove -y '^dotnet-.*'
           sudo apt-get remove -y '^temurin-.*'
-          sudo apt-get remove -y azure-cli google-cloud-cli microsoft-edge-stable google-chrome-stable firefox powershell mono-devel
+          sudo apt-get remove -y azure-cli microsoft-edge-stable google-chrome-stable firefox mono-devel
           sudo apt-get autoremove -y
           sudo apt-get clean
           df -h
@@ -124,7 +124,7 @@ jobs:
           sudo apt-get remove -y 'php.*'
           sudo apt-get remove -y '^dotnet-.*'
           sudo apt-get remove -y '^temurin-.*'
-          sudo apt-get remove -y azure-cli google-cloud-cli microsoft-edge-stable google-chrome-stable firefox powershell mono-devel
+          sudo apt-get remove -y azure-cli microsoft-edge-stable google-chrome-stable firefox mono-devel
           sudo apt-get autoremove -y
           sudo apt-get clean
           df -h

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -86,7 +86,6 @@ jobs:
       MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
       LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
       TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
-      RUSTUP_TOOLCHAIN: nightly # udeps needs nightly
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master
@@ -102,10 +101,8 @@ jobs:
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
         run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
-      - name: "Download and run cargo-udeps"
-        run: |
-          wget -O - -c https://github.com/est31/cargo-udeps/releases/download/v0.1.50/cargo-udeps-v0.1.50-x86_64-unknown-linux-gnu.tar.gz | tar -xz
-          cargo-udeps-*/cargo-udeps udeps --all-targets --all-features
+      - name: Machete
+        uses: bnjbvr/cargo-machete@main
 
   test:
     name: test (linux, amd64)
@@ -127,7 +124,7 @@ jobs:
           sudo apt-get remove -y 'php.*'
           sudo apt-get remove -y '^dotnet-.*'
           sudo apt-get remove -y '^temurin-.*'
-          sudo apt-get remove -y azure-cli google-cloud-cli microsoft-edge-stable google-chrome-stable firefox powershell mono-devel
+          sudo apt-get remove -y azure-cli microsoft-edge-stable google-chrome-stable firefox mono-devel
           sudo apt-get autoremove -y
           sudo apt-get clean
           df -h
@@ -218,7 +215,7 @@ jobs:
           sudo apt-get remove -y 'php.*'
           sudo apt-get remove -y '^dotnet-.*'
           sudo apt-get remove -y '^temurin-.*'
-          sudo apt-get remove -y azure-cli google-cloud-cli microsoft-edge-stable google-chrome-stable firefox powershell mono-devel
+          sudo apt-get remove -y azure-cli microsoft-edge-stable google-chrome-stable firefox mono-devel
           sudo apt-get autoremove -y
           sudo apt-get clean
           df -h
@@ -333,7 +330,7 @@ jobs:
           sudo apt-get remove -y 'php.*'
           sudo apt-get remove -y '^dotnet-.*'
           sudo apt-get remove -y '^temurin-.*'
-          sudo apt-get remove -y azure-cli google-cloud-cli microsoft-edge-stable google-chrome-stable firefox powershell mono-devel
+          sudo apt-get remove -y azure-cli microsoft-edge-stable google-chrome-stable firefox mono-devel
           sudo apt-get autoremove -y
           sudo apt-get clean
           df -h

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -65,7 +65,6 @@ cairo-lang-filesystem = "2.8.4"
 cairo-lang-semantic = "2.8.4"
 cairo-lang-sierra = "2.8.4"
 cairo-lang-sierra-generator = "2.8.4"
-cairo-lang-diagnostics = "2.8.4"
 educe = "0.5.11" # can't update until https://github.com/magiclen/educe/issues/27
 itertools = "0.13.0"
 lazy_static = "1.5"

diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml
@@ -13,7 +13,6 @@ starknet-types-core = { version = "0.1.7", default-features = false, features =
     "std", "serde", "hash"
 ] }
 cairo-lang-sierra-gas = "2.8.4"
-libc = "0.2"
 starknet-curve = "0.5.1"
 lazy_static = "1.5.0"
 rand = "0.8.5"